From: "Frans Klaver" <fransklaver@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Vijay Lakshminarayanan" <laksvij@gmail.com>
Cc: "Jeff King" <peff@peff.net>, "Stephen Bash" <bash@genarts.com>,
"git discussion list" <git@vger.kernel.org>
Subject: Re: Git blame only current branch
Date: Tue, 13 Dec 2011 15:18:31 +0100 [thread overview]
Message-ID: <op.v6fl05u30aolir@keputer> (raw)
In-Reply-To: <87y5ugsguj.fsf@gmail.com>
On Tue, 13 Dec 2011 15:09:56 +0100, Vijay Lakshminarayanan
<laksvij@gmail.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Vijay Lakshminarayanan <laksvij@gmail.com> writes:
>>
>>> The code reads fine when there's no numeral 1 around but now it doesn't
>>> read well. I think refactoring
>>>
>>> struct commit_list *l
>>>
>>> to
>>>
>>> struct commit_list *lst
>>>
>>> is justified. Thoughts?
>>
>> Not justified at all.
>>
>> What is "lst" and why is it not spelled "list"? It is a disease to drop
>> vowels when you do not have to.
>
> lst is better than l in this particular context. I think fried_chicken
> is better than l in this particular context ;-)
I tend to agree. If you casually look over the code it may look odd, and
with several monospace fonts there really isn't a very big difference
between 1?1:0 and l?1:0. You shouldn't have to squint to properly see the
intention of the code.
If there's going to be a rename, there is no reason to leave out the i
though.
next prev parent reply other threads:[~2011-12-13 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e9e35956-a091-4143-8fd4-3516b54263a6@mail>
2011-12-12 15:24 ` Git blame only current branch Stephen Bash
2011-12-12 16:55 ` Jeff King
2011-12-12 17:05 ` Stephen Bash
2011-12-12 17:19 ` andreas.t.auer_gtml_37453
2011-12-13 2:07 ` Vijay Lakshminarayanan
2011-12-13 2:14 ` Jeff King
2011-12-13 5:47 ` Junio C Hamano
2011-12-13 14:09 ` Vijay Lakshminarayanan
2011-12-13 14:18 ` Frans Klaver [this message]
2011-12-13 17:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v6fl05u30aolir@keputer \
--to=fransklaver@gmail.com \
--cc=bash@genarts.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=laksvij@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.