From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by ozlabs.org (Postfix) with ESMTP id 86E3B1007D1 for ; Mon, 2 Aug 2010 19:38:18 +1000 (EST) Received: from eu_spt2 (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0L6I00H0IQRMJ3@mailout2.w1.samsung.com> for linuxppc-dev@ozlabs.org; Mon, 02 Aug 2010 10:38:10 +0100 (BST) Received: from linux.samsung.com ([106.116.38.10]) by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0L6I001PIQRJGK@spt2.w1.samsung.com> for linuxppc-dev@ozlabs.org; Mon, 02 Aug 2010 10:38:09 +0100 (BST) Date: Mon, 02 Aug 2010 11:39:39 +0200 From: =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= Subject: Re: [PATCH RFC] usb gadget: introduce usb_gadget_probe_driver In-reply-to: <1280501361-13410-1-git-send-email-u.kleine-koenig@pengutronix.de> To: linux-usb@vger.kernel.org, =?utf-8?Q?Uwe_Kleine-K=C3=B6nig?= Message-id: MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed; delsp=yes References: <1280501361-13410-1-git-send-email-u.kleine-koenig@pengutronix.de> Cc: Cliff Cai , Mark Brown , Dan Carpenter , Tony Lindgren , Nicolas Ferre , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Julia Lawall , Philipp Zabel , Felipe Balbi , Andrea Gelmini , Robert Jarzmik , Fabien Chouteau , Dinh Nguyen , David Brownell , Vladimir Zapolskiy , Sergei Shtylyov , Vincent Sanders , Marc Singer , =?utf-8?Q?Andr=C3=A9_Goddard_Rosa?= , Alan Stern , Sean MacLennan , Russell King , Tobias Klauser , Anatolij Gustschin , Marc Kleine-Budde , Eirik Aanonsen , Mike Frysinger , Thomas Dahlmann , linux-geode@lists.infradead.org, Ben Dooks , Magnus Damm , Anton Vorontsov , Andrew Victor , linux-arm-kernel@lists.infradead.org, Eric Miao , =?utf-8?Q?N=C3=A9meth_M=C3=A1rton?= , Jiri Kosina , Yoshihiro Shimoda , Greg Kroah-Hartman , Harro Haan , FUJITA Tomonori , H Hartley Sweeten , Paul Mundt , Tejun Heo , Andrew Morton , Cory Maccarrone List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 30 Jul 2010 16:49:14 +0200, Uwe Kleine-K=C3=B6nig wrote: > by using usb_gadget_probe_driver with driver->bind =3D NULL. When all= > drivers are fixed to use the new function the bind member of struct > usb_gadget_driver can go away. On second thought, would it be hard to just fix all the gadgets? It's n= ot like there are thousands of them so it shouldn't take that long. Moreover, since y= ou'd remove the bind field and change the prototype of the usb_gadget_register() all= instances would be found at compile time. With that and the other functions which use bind callbacks (usb_add_conf= iguration(), usb_composite_register()) the patch would be much better in my opinion a= nd also much better then my approach with __ref. -- = Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=3D./ `o | Computer Science, Micha=C5=82 "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.nazarewicz@samsung.com (=?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?=) Date: Mon, 02 Aug 2010 11:39:39 +0200 Subject: [PATCH RFC] usb gadget: introduce usb_gadget_probe_driver In-Reply-To: <1280501361-13410-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <1280501361-13410-1-git-send-email-u.kleine-koenig@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 30 Jul 2010 16:49:14 +0200, Uwe Kleine-K?nig wrote: > by using usb_gadget_probe_driver with driver->bind = NULL. When all > drivers are fixed to use the new function the bind member of struct > usb_gadget_driver can go away. On second thought, would it be hard to just fix all the gadgets? It's not like there are thousands of them so it shouldn't take that long. Moreover, since you'd remove the bind field and change the prototype of the usb_gadget_register() all instances would be found at compile time. With that and the other functions which use bind callbacks (usb_add_configuration(), usb_composite_register()) the patch would be much better in my opinion and also much better then my approach with __ref. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Micha? "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--