All of lore.kernel.org
 help / color / mirror / Atom feed
From: kaloz@openwrt.org (Imre Kaloz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: support XZ compressed kernels
Date: Fri, 22 Jul 2011 12:27:18 +0200	[thread overview]
Message-ID: <op.vy0nbsz22s3iss@ecaz> (raw)
In-Reply-To: <20110722095738.GE21416@n2100.arm.linux.org.uk>

On Fri, 22 Jul 2011 11:57:38 +0200, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> On Fri, Jul 22, 2011 at 11:52:19AM +0200, Imre Kaloz wrote:
>
>> Guessed I'm not the one outside the ARM community, so.. I can say it
>> didn't break neither ppc or mips for me, but have no idea who's feedback
>> are you waiting for.
>
> What I'm concerned about is the apparant lack of exposure of the patch
> to people outside of ARM, especially as it touches lib/xz/xz_dec_stream.c.
>
> I have no idea whether that breaks some architecture or not.
>
> Is Lasse Collin (the original contributer of that file) aware of this
> change?
>
> What is the additional include fixing on ARM?  Why isn't this include
> needed on other architectures?  And why isn't any of this mentioned in
> the patch commit log?
>

It's needed because of missing min_t - but just looked a bit further and it seems decompress.c should use kernel.h - so I send v3 right away with the following change if you agree:

--- a/arch/arm/boot/compressed/decompress.c
+++ b/arch/arm/boot/compressed/decompress.c
@@ -1,7 +1,7 @@
  #define _LINUX_STRING_H_

  #include <linux/compiler.h>	/* for inline */
-#include <linux/types.h>	/* for size_t */
+#include <linux/kernel.h>	/* for min_t */
  #include <linux/stddef.h>	/* for NULL */
  #include <linux/linkage.h>
  #include <asm/string.h>

  reply	other threads:[~2011-07-22 10:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12 12:56 [PATCH v2] ARM: support XZ compressed kernels Imre Kaloz
2011-07-15 16:25 ` Russell King - ARM Linux
2011-07-16 14:07   ` Imre Kaloz
2011-07-19 11:02     ` Russell King - ARM Linux
2011-07-19 11:07       ` Russell King - ARM Linux
2011-07-22  9:16         ` Russell King - ARM Linux
2011-07-22  9:52           ` Imre Kaloz
2011-07-22  9:57             ` Russell King - ARM Linux
2011-07-22 10:27               ` Imre Kaloz [this message]
2011-07-22 12:50               ` Russell King - ARM Linux
2011-07-22 19:57                 ` Imre Kaloz
2011-07-22 20:07                   ` Russell King - ARM Linux
2011-07-19 11:09       ` Imre Kaloz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.vy0nbsz22s3iss@ecaz \
    --to=kaloz@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.