From: "Glenn Kennard" <glenn.kennard@gmail.com>
To: Jerome Glisse <j.glisse@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: evergreen/cayman indirect draw support
Date: Sun, 09 Nov 2014 00:50:34 +0100 [thread overview]
Message-ID: <op.xo05ukoxv3yd1p@nemesis> (raw)
In-Reply-To: <20141108231548.GA5883@gmail.com>
On Sun, 09 Nov 2014 00:15:49 +0100, Jerome Glisse <j.glisse@gmail.com>
wrote:
> On Sat, Nov 08, 2014 at 11:51:30PM +0100, Glenn Kennard wrote:
>> Signed-off-by: Glenn Kennard <glenn.kennard@gmail.com>
>
> NAK insecure. This is missing any kind of boundary checking for the
> indirect buffer and thus can be abuse.
The indirect command buffer is a fixed format 16 or 20 bytes size, read by
fixed function hardware, which only contains the following:
For PACKET3_DRAW_INDIRECT:
typedef struct {
GLuint count;
GLuint primCount;
GLuint first;
GLuint reservedMustBeZero;
} DrawArraysIndirectCommand;
or PACKET3_DRAW_INDEX_INDIRECT:
typedef struct {
GLuint count;
GLuint primCount;
GLuint firstIndex;
GLint baseVertex;
GLuint reservedMustBeZero;
} DrawElementsIndirectCommand;
Please outline an example of how this would be abused.
/Glenn
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-11-08 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 22:51 [PATCH] drm/radeon: evergreen/cayman indirect draw support Glenn Kennard
2014-11-08 23:15 ` Jerome Glisse
2014-11-08 23:50 ` Glenn Kennard [this message]
2014-11-09 12:19 ` Marek Olšák
2014-12-13 2:32 ` [PATCH v2] " Glenn Kennard
2014-12-15 11:44 ` Marek Olšák
2014-12-15 15:59 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.xo05ukoxv3yd1p@nemesis \
--to=glenn.kennard@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.glisse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.