All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <oliva@gnu.org>
To: Loic Dachary <loic@dachary.org>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] daemons: write pid file even when told not to daemonize
Date: Thu, 04 Sep 2014 16:48:04 -0300	[thread overview]
Message-ID: <ortx4n416z.fsf@free.home> (raw)
In-Reply-To: <54003C8B.8090000@dachary.org> (Loic Dachary's message of "Fri, 29 Aug 2014 10:40:43 +0200")

On Aug 29, 2014, Loic Dachary <loic@dachary.org> wrote:

> After a quick glance at the systemd man page http://www.freedesktop.org/software/systemd/man/systemd.service.html#Options it seems possible to do something like

>     https://github.com/dachary/ceph/compare/wip-systemd?expand=1

Yeah, it sure is possible in systemd to start and track daemons that
don't have a “run in foreground” option, but it's not as efficient.

> Alternatively, shouldn't systemctl kill ceph-osd@10.service be the canonical way of killing a process spawned by systemd ?

If you know what number to use after @, I guess it would.  I don't think
we're talking about the same version of ceph, when it comes to systemd
config files.  Your patch doesn't modify any file present on my system
(still running 0.80.5)

> If both are impractical or frowned upon for some reason, it looks like
> your patch is the only way to go, indeed.

It's certainly not the only way to go, but silently dropping a command
line option sounds like a bug to me.  Of course the patch I proposed
isn't the only way to go about that...

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-09-04 19:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31  2:08 [PATCH] daemons: write pid file even when told not to daemonize Alexandre Oliva
2014-07-31  4:18 ` Loic Dachary
2014-07-31  4:30   ` Sage Weil
2014-08-28  7:35     ` Alexandre Oliva
2014-08-28  8:09       ` Loic Dachary
2014-08-29  6:41         ` Alexandre Oliva
2014-08-29  8:40           ` Loic Dachary
2014-09-04 19:48             ` Alexandre Oliva [this message]
2014-09-09 22:21 ` Sage Weil
2014-09-09 22:48   ` Loic Dachary
2014-09-09 22:54     ` Sage Weil
2014-09-12 10:22 ` Loic Dachary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ortx4n416z.fsf@free.home \
    --to=oliva@gnu.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=loic@dachary.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.