From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C5EC2B9F4 for ; Tue, 22 Jun 2021 05:01:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25204611AF for ; Tue, 22 Jun 2021 05:01:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25204611AF Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.145739.268035 (Exim 4.92) (envelope-from ) id 1lvYXU-0006lc-2y; Tue, 22 Jun 2021 05:01:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 145739.268035; Tue, 22 Jun 2021 05:01:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lvYXT-0006lV-WD; Tue, 22 Jun 2021 05:01:32 +0000 Received: by outflank-mailman (input) for mailman id 145739; Tue, 22 Jun 2021 05:01:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lvYXS-0006lL-OZ; Tue, 22 Jun 2021 05:01:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lvYXS-0002qp-Gj; Tue, 22 Jun 2021 05:01:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lvYXS-0003WQ-7X; Tue, 22 Jun 2021 05:01:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1lvYXS-000059-70; Tue, 22 Jun 2021 05:01:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4QacmPXLgDr2zwdzsqChu7E/ZQnn+idYeogiDccWEyU=; b=f/IdhYDX7fYU9OCUxx8sI6ltp3 wCMyR8q2OFw5rCQLJ7SdoDlUYPt9UwOmQ4MCvPmgSOeifcyPgH8jjplvYq0uGIkrXsDtNXXKmxaNW n2e8igHgCLZF473UY8Gjj90DyBa9Y9bAj6JWsejCsJpNX4DHt9Cg+DTcWrNdsHvTCkoY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 162955: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-amd64::broken:regression xen-unstable-smoke:build-arm64-xsm::broken:regression xen-unstable-smoke:build-arm64-xsm:host-install(4):broken:regression xen-unstable-smoke:build-amd64:host-install(4):broken:regression xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c9b59f9032d41be8bade8a25d9148cf6ed203704 X-Osstest-Versions-That: xen=8af4b47f061edf6450f2b0a0a8134fdf1c13b3e5 From: osstest service owner Date: Tue, 22 Jun 2021 05:01:30 +0000 flight 162955 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/162955/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-arm64-xsm broken build-arm64-xsm 4 host-install(4) broken REGR. vs. 162880 build-amd64 4 host-install(4) broken REGR. vs. 162880 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c9b59f9032d41be8bade8a25d9148cf6ed203704 baseline version: xen 8af4b47f061edf6450f2b0a0a8134fdf1c13b3e5 Last test of basis 162880 2021-06-17 17:00:36 Z 4 days Testing same since 162942 2021-06-21 16:00:26 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Nick Rosbrook Nick Rosbrook jobs: build-arm64-xsm broken build-amd64 broken build-armhf pass build-amd64-libvirt blocked test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-amd64 broken broken-job build-arm64-xsm broken broken-step build-arm64-xsm host-install(4) broken-step build-amd64 host-install(4) Not pushing. ------------------------------------------------------------ commit c9b59f9032d41be8bade8a25d9148cf6ed203704 Author: Nick Rosbrook Date: Mon May 24 16:36:52 2021 -0400 golang/xenlight: do not negate ret when converting to Error Commit 871e51d2d4 changed the sign on the xenlight error types (making the values negative, same as the C-generated constants), but failed to remove the code changing the sign before casting to Error(). This results in error strings like "libxl error: ", rather than the correct message. Fix all occurrances of this by running: gofmt -w -r 'Error(-ret) -> Error(ret)' xenlight.go from tools/golang/xenlight. Signed-off-by: Nick Rosbrook Acked-by: George Dunlap commit 1d95fd75df18bf25cb445feb47caf62da25c00e8 Author: Nick Rosbrook Date: Mon May 24 16:36:51 2021 -0400 golang/xenlight: add SendTrigger wrapper Add a warpper around libxl_send_trigger. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap commit 9b6d865e0af56e376740ba03b1ccdf316362a71e Author: Nick Rosbrook Date: Mon May 24 16:36:50 2021 -0400 golang/xenlight: add DomainDestroy wrapper Add a wrapper around libxl_domain_destroy. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap commit c089de0e2fa56d846cfb658b7b5efc3426895973 Author: Nick Rosbrook Date: Mon May 24 16:36:47 2021 -0400 golang/xenlight: rename Ctx receivers to ctx As a matter of style, it is strange to see capitalized receiver names, due to the significance of capitalized symbols in Go (although there is in fact nothing special about a capitalized receiver name). Fix this in xenlight.go by running: gofmt -w -r 'Ctx -> ctx' xenlight.go from tools/golang/xenlight. There is no functional change. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap commit 1997940ad25e3566d1ab38496b8c7b07a086695a Author: Nick Rosbrook Date: Mon May 24 16:36:46 2021 -0400 golang/xenlight: use struct pointers in keyed union fields Currently, when marshalig Go types with keyed union fields, we assign the value of the struct (e.g. DomainBuildInfoTypeUnionHvm) which implements the interface of the keyed union field (e.g. DomainBuildInfoTypeUnion). As-is, this means that if a populated DomainBuildInfo is marshaled to e.g. JSON, unmarshaling back to DomainBuildInfo will fail. When the encoding/json is unmarshaling data into a Go type, and encounters a JSON object, it basically can either marshal the data into an empty interface, a map, or a struct. It cannot, however, marshal data into an interface with at least one method defined on it (e.g. DomainBuildInfoTypeUnion). Before this check is done, however, the decoder will check if the Go type is a pointer, and dereference it if so. It will then use the type of this value as the "target" type. This means that if the TypeUnion field is populated with a DomainBuildInfoTypeUnion, the decoder will see a non-empty interface and fail. If the TypeUnion field is populated with a *DomainBuildInfoTypeUnionHvm, it dereferences the pointer and sees a struct instead, allowing decoding to continue normally. Since there does not appear to be a strict need for NOT using pointers in these fields, update code generation to set keyed union fields to pointers of their implementing structs. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap commit bc9f632e31ee66be3f1860fc7303fe91a42e56a6 Author: Nick Rosbrook Date: Mon May 24 16:36:45 2021 -0400 golang/xenlight: export keyed union interface types For structs that have a keyed union, e.g. DomainBuildInfo, the TypeUnion field must be exported so that package users can get/set the fields within. This means that users are aware of the existence of the interface type used in those fields (see [1]), so it is awkward that the interface itself is not exported. However, the single method within the interface must remain unexported so that users cannot mistakenly "implement" those interfaces. Since there seems to be no reason to do otherwise, export the keyed union interface types. [1] https://pkg.go.dev/xenbits.xenproject.org/git-http/xen.git/tools/golang/xenlight?tab=doc#DeviceUsbdev Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap commit 1422d8db1b3dfdf7d9179944e594876e5e356a4b Author: Nick Rosbrook Date: Mon May 24 16:36:43 2021 -0400 golang/xenlight: fix StringList toC conversion The current implementation of StringList.toC does not correctly account for how libxl_string_list is expected to be laid out in C, which is clear when one looks at libxl_string_list_length in libxl.c. In particular, StringList.toC does not account for the extra memory that should be allocated for the "sentinel" entry. And, when using the "slice trick" to create a slice that can address C memory, the unsafe.Pointer conversion should be on a C.libxl_string_list, not *C.libxl_string_list. Fix these problems by (1) allocating an extra slot in the slice used to address the C memory, and explicity set the last entry to nil so the C memory will be zeroed out, and (2) dereferencing csl in the unsafe.Pointer conversion. Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap commit b291ce703b9cebef0800267446334e867588354a Author: Nick Rosbrook Date: Mon May 24 16:36:42 2021 -0400 golang/xenlight: update generated code Re-generate code to reflect changes to libxl_types.idl from the following commits: 0570d7f276 x86/msr: introduce an option for compatible MSR behavior selection 7e5cffcd1e viridian: allow vCPU hotplug for Windows VMs 9835246710 viridian: remove implicit limit of 64 VPs per partition Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap (qemu changes not included)