From: Thierry Martinez <Thierry.Martinez@inria.fr>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] Python 3.10 again: _Py_fopen deprecated
Date: Sat, 09 Jan 2021 00:10:18 +0100 [thread overview]
Message-ID: <ow4mtxjyqhx.fsf@inria.fr> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2101082341230.2796@hadrien>
Hi, Richard.
Thank you very much for your two successive reports about
incompatibilities between pyml and Python 3.10. They should have been
fixed now.
Richard:
>> What I don't understand from the pyxml code is why we use these
>> internal Python functions at all, instead of calling regular C
>> functions like fopen etc. In fact it seems like for Python 2 we did
>> call fopen ...
Indeed, for Python 2, there is a fallback to fopen since Py_fopen is not
available. When Py_fopen or Py_wfopen are available, we prefer to use
them because they handle the Windows special case.
Best regards.
--
Thierry.
Julia Lawall :
> On Tue, 5 Jan 2021, Richard W.M. Jones wrote:
>
>> Firstly a gentle reminder that there's a patch waiting to be applied:
>> https://systeme.lip6.fr/pipermail/cocci/2020-November/thread.html#8398
>>
>> Different from that patch, but still related to Python 3.10, we've got
>> another bug report here:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1912931
>>
>> This time _Py_fopen has been deprecated, replaced by _Py_wfopen or
>> _Py_fopen_obj. It's unclear which is better. The two functions are
>> documented here:
>> https://github.com/python/cpython/blob/master/Python/fileutils.c#L1418
>>
>> What I don't understand from the pyxml code is why we use these
>> internal Python functions at all, instead of calling regular C
>> functions like fopen etc. In fact it seems like for Python 2 we did
>> call fopen ...
>
> Everything should be up to date now on github. Thanks for your help.
> Thierry will contact you directly about the choice of fopen.
>
> julia
>
>>
>> Rich.
>>
>> --
>> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
>> Read my programming and virtualization blog: http://rwmj.wordpress.com
>> Fedora Windows cross-compiler. Compile Windows programs, test, and
>> build Windows installers. Over 100 libraries supported.
>> http://fedoraproject.org/wiki/MinGW
>>
>> _______________________________________________
>> Cocci mailing list
>> Cocci@systeme.lip6.fr
>> https://systeme.lip6.fr/mailman/listinfo/cocci
>>
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2021-01-08 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 19:00 [Cocci] Python 3.10 again: _Py_fopen deprecated Richard W.M. Jones
2021-01-08 22:42 ` Julia Lawall
2021-01-08 23:10 ` Thierry Martinez [this message]
2021-01-09 9:10 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ow4mtxjyqhx.fsf@inria.fr \
--to=thierry.martinez@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.