All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Arver <linusa@google.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: [BUG] git commit --trailer --verbose puts trailer below scissors line
Date: Fri, 16 Feb 2024 14:34:48 -0800	[thread overview]
Message-ID: <owlyeddc82d3.fsf@fine.c.googlers.com> (raw)
In-Reply-To: <8b4738ad-62cd-789e-712e-bd45a151b4ac@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

> Hello,
>
> I've just found a bug in the current master: running
>
> 	git commit --trailer="key: value" --verbose
>
> puts the trailer below the diff, and thus below the scissors
> line (and so it is discarded).
>
> I checked that it works OK in 2.42.1 but not in 2.43.2 so it is not
> a new regression in the 2.44 cycle, but I thought I'd write now in case
> someone spots the culprit commit faster than me.
>
> I'll start a bisection now.
>
> Cheers,
>
> Philippe.

Thank you for the bug report. Looking forward to reviewing it (I am also
interested because I am in the middle of a large cleanup of
trailer.{c,h} [1]).

[1] https://lore.kernel.org/git/owlyplwx87s9.fsf@fine.c.googlers.com/

  parent reply	other threads:[~2024-02-16 22:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 21:04 [BUG] git commit --trailer --verbose puts trailer below scissors line Philippe Blain
2024-02-16 21:19 ` Junio C Hamano
2024-02-16 22:34 ` Linus Arver [this message]
2024-02-17  6:04 ` Jeff King
2024-02-19 17:41   ` Philippe Blain
2024-02-19 18:42     ` Junio C Hamano
2024-02-20  1:09       ` [PATCH] trailer: fix comment/cut-line regression with opts->no_divider Jeff King
2024-02-20  3:26         ` Junio C Hamano
2024-03-08  2:21         ` Linus Arver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=owlyeddc82d3.fsf@fine.c.googlers.com \
    --to=linusa@google.com \
    --cc=git@vger.kernel.org \
    --cc=levraiphilippeblain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.