From: Linus Arver <linusa@google.com>
To: Jeff King <peff@peff.net>,
Linus Arver via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] strvec: use correct member name in comments
Date: Fri, 12 Jan 2024 10:04:43 -0800 [thread overview]
Message-ID: <owlyo7dqig1w.fsf@fine.c.googlers.com> (raw)
In-Reply-To: <20240112074138.GH618729@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> The source of the problem is that the patch originally used
> "items" in the struct, too
Ah, that makes sense.
> As you note, we still call use "items" for the vector passed in to
> pushv. I think that is OK, and there is no real need to use the terse
> "v" there (it is also purely internal; the declaration in strvec.h does
> not name it at all).
Indeed. Perhaps I should have included this in my commit message.
Side note: should we start naming the parameters in strvec.h? I would
think that it wouldn't hurt at this point (as the API is pretty stable).
If you think that's worth it, I could reroll to include that in this
series (and also improve my commit message for this patch).
next prev parent reply other threads:[~2024-01-12 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 7:06 [PATCH] strvec: use correct member name in comments Linus Arver via GitGitGadget
2024-01-12 7:41 ` Jeff King
2024-01-12 18:04 ` Linus Arver [this message]
2024-01-12 21:47 ` Junio C Hamano
2024-01-13 0:37 ` Linus Arver
2024-01-13 7:31 ` Jeff King
2024-01-14 18:20 ` Linus Arver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=owlyo7dqig1w.fsf@fine.c.googlers.com \
--to=linusa@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.