From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTA2s-0005Wk-N5 for qemu-devel@nongnu.org; Mon, 07 Oct 2013 08:36:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTA2k-0007TV-P9 for qemu-devel@nongnu.org; Mon, 07 Oct 2013 08:36:18 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:54127 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTA2k-0007QB-Ih for qemu-devel@nongnu.org; Mon, 07 Oct 2013 08:36:10 -0400 References: <1380913658-23729-1-git-send-email-mohamad.gebai@polymtl.ca> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1380913658-23729-1-git-send-email-mohamad.gebai@polymtl.ca> Date: Mon, 07 Oct 2013 13:36:08 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH v2 0/3] Fix UST backend for LTTng 2.x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mohamad Gebai Cc: Mohamad Gebai , qemu-devel@nongnu.org mohamad.gebai@gmail.com writes: > Version 2 > > * Fix tracepoint generation error in first version. > * Avoid warnings and errors specific to LTTng ust 2.0. > * If using LTTng ust 2.0, we can't avoid getting warnings because of the > --warn-common option given to the linker. This is fixed in more recent > versions of LTTng ust. Looking good. Builds for me now although I need to do some reading to actually test it out. One omission is docs/tracing.txt gives examples for the other tracing backend but just refers to "UST utilities should be used to list, enable/disable, and dump traces.". Perhaps a few simple examples could be added to the document so people can at least confirm everything is working as it should be. Otherwise I'm happy. Reviewed-by: Alex Bennée > > Mohamad > > Mohamad Gebai (3): > Fix configure script for LTTng 2.x > Modified the tracetool framework for LTTng 2.x. > Adapt Makefiles to the new LTTng ust interface. > > Makefile | 5 ++ > configure | 9 ++-- > scripts/tracetool/backend/events.py | 44 ++++++++++++++++ > scripts/tracetool/backend/ust.py | 82 ++++++------------------------ > scripts/tracetool/format/ust_events_c.py | 30 +++++++++++ > scripts/tracetool/format/ust_events_h.py | 57 +++++++++++++++++++++ > trace/Makefile.objs | 29 ++++++++++- > 7 files changed, 183 insertions(+), 73 deletions(-) > create mode 100644 scripts/tracetool/format/ust_events_c.py > create mode 100644 scripts/tracetool/format/ust_events_h.py -- Alex Bennée