All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Mohamad Gebai <mohamad.gebai@gmail.com>
Cc: Mohamad Gebai <mohamad.gebai@polymtl.ca>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/3] Fix UST backend for LTTng 2.x
Date: Tue, 01 Oct 2013 11:04:04 +0100	[thread overview]
Message-ID: <p1r4c5b94b.fsf@linaro.org> (raw)
In-Reply-To: <1380553501-20670-1-git-send-email-mohamad.gebai@polymtl.ca>


mohamad.gebai@gmail.com writes:

> These patches fix the UST backend which got broken by LTTng 2.x.
>
> An interesting new feature in LTTng 2.x is that tracepoints now need to belong
> to a provider. A provider is a way to group tracepoints in a logical way, for
> instance tracepoints that belong to a specific file or subsystem. This would
> then allow users to enable all tracepoints of a specific provider at once.
>
> In these patches, only one provider is defined, which is called "ust" (and
> tracepoints are defined in generated-ust-provider.h). It would be interesting to
> take advantage of this feature in the future, separating tracepoints into
> multiple providers. Of course, this would require more modifications as well as
> a way to specify to which provider each tracepoint belongs in file trace-events.
>
I'm getting loads of compile failures like:

./trace/generated-tracers.h: In function ‘trace_esp_dma_enable’:
./trace/generated-tracers.h:3355:1: error: expected expression before ‘)’ token
./trace/generated-tracers.h:3355:1: error: expected expression before ‘)’ token
./trace/generated-tracers.h:3355:1: error: expected expression before ‘)’ token
./trace/generated-tracers.h:3355:1: error: implicit declaration of function ‘__tracepoint_cb_ust___esp_dma_enable’ [-Werror=implicit-function-declaration]
./trace/generated-tracers.h:3355:1: error: nested extern declaration of ‘__tracepoint_cb_ust___esp_dma_enable’ [-Werror=nested-externs]

The code looks like:

static inline void trace_esp_dma_enable(void)
{
    tracepoint(ust, esp_dma_enable, );
}

So I assume it's the included stuff that's falling over.

This is on Ubuntu 12.04 LTS with:

11:03 ajb@sloy/x86_64 [qemu.git] >dpkg -l | grep tng
ii  liblttng-ust-dev                                    2.0.2-0ubuntu1                                      LTTng 2.0 Userspace Tracer (development files)
ii  liblttng-ust0                                       2.0.2-0ubuntu1                                      LTTng 2.0 Userspace Tracer (libraries)

-- 
Alex Bennée

      parent reply	other threads:[~2013-10-01 10:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 15:04 [Qemu-devel] [RFC PATCH 0/3] Fix UST backend for LTTng 2.x Mohamad Gebai
2013-09-30 15:04 ` [Qemu-devel] [RFC PATCH 1/3] Fix configure script " Mohamad Gebai
2013-09-30 15:05 ` [Qemu-devel] [RFC PATCH 2/3] Modified the tracetool framework " Mohamad Gebai
2013-09-30 15:05 ` [Qemu-devel] [RFC PATCH 3/3] Adapt Makefiles to the new LTTng ust interface Mohamad Gebai
2013-10-01 10:04 ` Alex Bennée [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p1r4c5b94b.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=mohamad.gebai@gmail.com \
    --cc=mohamad.gebai@polymtl.ca \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.