From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54627)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VQwoO-0006iZ-Jd
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 06:04:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VQwoI-0005T2-HI
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 06:04:12 -0400
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:52591 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1VQwoI-0005Se-AI
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 06:04:06 -0400
References: <1380553501-20670-1-git-send-email-mohamad.gebai@polymtl.ca>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1380553501-20670-1-git-send-email-mohamad.gebai@polymtl.ca>
Date: Tue, 01 Oct 2013 11:04:04 +0100
Message-ID: <p1r4c5b94b.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC PATCH 0/3] Fix UST backend for LTTng 2.x
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mohamad Gebai <mohamad.gebai@gmail.com>
Cc: Mohamad Gebai <mohamad.gebai@polymtl.ca>, qemu-devel@nongnu.org


mohamad.gebai@gmail.com writes:

> These patches fix the UST backend which got broken by LTTng 2.x.
>
> An interesting new feature in LTTng 2.x is that tracepoints now need to belong
> to a provider. A provider is a way to group tracepoints in a logical way, for
> instance tracepoints that belong to a specific file or subsystem. This would
> then allow users to enable all tracepoints of a specific provider at once.
>
> In these patches, only one provider is defined, which is called "ust" (and
> tracepoints are defined in generated-ust-provider.h). It would be interesting to
> take advantage of this feature in the future, separating tracepoints into
> multiple providers. Of course, this would require more modifications as well as
> a way to specify to which provider each tracepoint belongs in file trace-events.
>
I'm getting loads of compile failures like:

./trace/generated-tracers.h: In function ‘trace_esp_dma_enable’:
./trace/generated-tracers.h:3355:1: error: expected expression before ‘)’ token
./trace/generated-tracers.h:3355:1: error: expected expression before ‘)’ token
./trace/generated-tracers.h:3355:1: error: expected expression before ‘)’ token
./trace/generated-tracers.h:3355:1: error: implicit declaration of function ‘__tracepoint_cb_ust___esp_dma_enable’ [-Werror=implicit-function-declaration]
./trace/generated-tracers.h:3355:1: error: nested extern declaration of ‘__tracepoint_cb_ust___esp_dma_enable’ [-Werror=nested-externs]

The code looks like:

static inline void trace_esp_dma_enable(void)
{
    tracepoint(ust, esp_dma_enable, );
}

So I assume it's the included stuff that's falling over.

This is on Ubuntu 12.04 LTS with:

11:03 ajb@sloy/x86_64 [qemu.git] >dpkg -l | grep tng
ii  liblttng-ust-dev                                    2.0.2-0ubuntu1                                      LTTng 2.0 Userspace Tracer (development files)
ii  liblttng-ust0                                       2.0.2-0ubuntu1                                      LTTng 2.0 Userspace Tracer (libraries)

-- 
Alex Bennée