From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX9xk-0006k4-0z for qemu-devel@nongnu.org; Fri, 18 Oct 2013 09:19:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VX9xb-0006BO-FH for qemu-devel@nongnu.org; Fri, 18 Oct 2013 09:19:31 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:35917 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX9xb-0006BI-8h for qemu-devel@nongnu.org; Fri, 18 Oct 2013 09:19:23 -0400 References: <1382096703-31938-1-git-send-email-alex.bennee@linaro.org> <1382096703-31938-2-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Fri, 18 Oct 2013 14:19:20 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Claudio Fontana , QEMU Developers , Andreas =?utf-8?Q?F=C3=A4rber?= peter.maydell@linaro.org writes: > On 18 October 2013 12:45, wrote: >> From: Alex Bennée >> >> Commit 9b8c69243 (since reverted) broke the ability to boot the kernel >> as the value returned by unassigned_mem_read returned non-zero and left >> the kernel looping forever waiting for it to change (see >> integrator_led_set in the kernel code). >> >> Relying on a varying implementation detail is incorrect anyway so this >> introduces a basic stub of a memory region for the debug/LED section >> on the integrator board. >> >> Signed-off-by: Alex Bennée >> --- >> hw/arm/Makefile.objs | 3 +- >> hw/arm/integrator_debug.c | 103 ++++++++++++++++++++++++++++++++++++++ > > Oh, and this belongs in hw/misc/, since it's a standalone > device model. Ahh I was pondering this. Surely as it's only associated with ARM (and specifically integrator) it gets grouped with that? I was following up on Andreas' comments and deciding between: hw/misc/arm_integrator_debug.c with include/hw/misc/arm_integrator_debug.c and what I went with. The existing devices are a mix of inline ones in integratorcp.c and integrator_pit which is in hw/timer/arm_timer.c. Perhaps there should be an addendum to HACKING.txt or a doc/src_layout.txt? -- Alex Bennée