From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Claudio Fontana" <claudio.fontana@huawei.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region
Date: Fri, 18 Oct 2013 13:37:47 +0100 [thread overview]
Message-ID: <p1wqlan49w.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_WTRhwg71qBwPsbMD8mtzA=objLk4Kzv4=pqg9AGC1rA@mail.gmail.com>
peter.maydell@linaro.org writes:
> On 18 October 2013 12:45, <alex.bennee@linaro.org> wrote:
>> +typedef struct {
>> + SysBusDevice parent_obj;
>> +
>> + MemoryRegion iomem;
>> +
>> + uint32_t alpha;
>> + uint32_t leds;
>> + uint32_t switches;
>
> These three fields are never used, or did I miss something?
Nope, I obviously had thoughts of tracking the actual LED/Switch state
and never added it in.
>
>> +} IntegratorDebugState;
>
> Looks good otherwise.
>
> thanks
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2013-10-18 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 11:45 [Qemu-devel] [PATCH v3 0/1] integrator: fix Linux boot failure alex.bennee
2013-10-18 11:45 ` [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region alex.bennee
2013-10-18 11:49 ` Peter Maydell
2013-10-18 12:37 ` Alex Bennée [this message]
2013-10-18 13:01 ` Peter Maydell
2013-10-18 13:19 ` Alex Bennée
2013-10-18 13:30 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p1wqlan49w.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=afaerber@suse.de \
--cc=claudio.fontana@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.