From: Andi Kleen <andi@firstfloor.org>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)
Date: 29 Nov 2007 11:29:48 +0100 [thread overview]
Message-ID: <p734pf59wf7.fsf@crumb.suse.de> (raw)
In-Reply-To: <474C34CC.6060509@gmail.com>
Vegard Nossum <vegard.nossum@gmail.com> writes:
>
> - We properly flush TLB entries that change. This used to not be the case, and so we
For low values of "properly" @)
> + pte = lookup_address(addr);
> + change_page_attr(page, 1, __pgprot(pte->pte_low | _PAGE_VISIBLE));
> + __flush_tlb_one(addr);
That's not enough, you need to flush all CPUs.
Also when you don't call global_flush_tlb() eventually because c_p_a() will leak flush
objects over time.
-Andi
next prev parent reply other threads:[~2007-11-29 10:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 15:16 [RFC] kmemcheck: trap uses of uninitialized memory (v2) Vegard Nossum
2007-11-28 6:51 ` Richard Knutsson
2007-11-28 18:31 ` Vegard Nossum
2007-11-29 4:49 ` Richard Knutsson
2007-11-29 8:02 ` Pekka Enberg
2007-11-29 9:10 ` Vegard Nossum
2007-11-29 9:39 ` Pekka J Enberg
2007-11-29 10:04 ` Vegard Nossum
2007-11-29 12:05 ` Pekka J Enberg
2007-11-29 10:29 ` Andi Kleen [this message]
2007-11-29 13:24 ` Vegard Nossum
2007-11-29 13:45 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p734pf59wf7.fsf@crumb.suse.de \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.