From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (mx1.suse.de [195.135.220.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.suse.de", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 22A09DE01B for ; Sat, 7 Jul 2007 03:19:31 +1000 (EST) Sender: ak@suse.de To: "H. Peter Anvin" Subject: Re: Too verbose compat_ioctl messages? References: <468E6E33.3040000@zytor.com> From: Andi Kleen Date: 06 Jul 2007 20:14:39 +0200 In-Reply-To: <468E6E33.3040000@zytor.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Geert Uytterhoeven , Linux/PPC Development , Linux Kernel Development , Hiroaki Fuse List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , "H. Peter Anvin" writes: > > For one thing, it looks like we're returning the wrong thing (EINVAL > rather than ENOTTY) across the board. This was unfortunately a common > misunderstanding with non-tty-related ioctls in the early days of Linux. ENOTTY is so excessively misnamed that it is actually surprising anybody ever got that "right" (for very small values of right i guess) -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764056AbXGFRTh (ORCPT ); Fri, 6 Jul 2007 13:19:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762622AbXGFRT1 (ORCPT ); Fri, 6 Jul 2007 13:19:27 -0400 Received: from ns1.suse.de ([195.135.220.2]:38768 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761199AbXGFRT0 (ORCPT ); Fri, 6 Jul 2007 13:19:26 -0400 To: "H. Peter Anvin" Cc: Geert Uytterhoeven , Linux Kernel Development , Linux/PPC Development , Hiroaki Fuse Subject: Re: Too verbose compat_ioctl messages? References: <468E6E33.3040000@zytor.com> From: Andi Kleen Date: 06 Jul 2007 20:14:39 +0200 In-Reply-To: <468E6E33.3040000@zytor.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org "H. Peter Anvin" writes: > > For one thing, it looks like we're returning the wrong thing (EINVAL > rather than ENOTTY) across the board. This was unfortunately a common > misunderstanding with non-tty-related ioctls in the early days of Linux. ENOTTY is so excessively misnamed that it is actually surprising anybody ever got that "right" (for very small values of right i guess) -Andi