All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Cc: emoenke@gwdg.de, minyard@wf-rch.cirr.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use spinlock instead of binary mutex in CDU-31A driver
Date: 23 Apr 2007 01:25:58 +0200	[thread overview]
Message-ID: <p737is43sah.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070422213531.GO5013@traven>

Matthias Kaehlcke <matthias.kaehlcke@gmail.com> writes:

> -static DECLARE_MUTEX(sony_sem);		/* Semaphore for drive hardware access */
> +static DEFINE_MUTEX(sony_mtx);		/* Mutex for drive hardware access */

That's not a spinlock.  Also normally some rationale is added to the
description for a change?

-Andi

  reply	other threads:[~2007-04-22 22:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-22 21:35 [PATCH] use spinlock instead of binary mutex in CDU-31A driver Matthias Kaehlcke
2007-04-22 23:25 ` Andi Kleen [this message]
2007-04-23  5:42   ` Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p737is43sah.fsf@bingen.suse.de \
    --to=andi@firstfloor.org \
    --cc=emoenke@gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.kaehlcke@gmail.com \
    --cc=minyard@wf-rch.cirr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.