From: Andi Kleen <ak@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add execute_in_process_context() API
Date: 08 Feb 2006 09:06:51 +0100 [thread overview]
Message-ID: <p737j86l1es.fsf@verdi.suse.de> (raw)
In-Reply-To: <1139342419.6065.8.camel@mulgrave.il.steeleye.com.suse.lists.linux.kernel>
James Bottomley <James.Bottomley@SteelEye.com> writes:
In general this seems like a lot of code for a simple problem.
It might be simpler to just put the work structure into the parent
object and do the workqueue unconditionally
> + if (unlikely(!wqw)) {
> + printk(KERN_ERR "Failed to allocate memory\n");
> + WARN_ON(1);
WARN_ON for GFP_ATOMIC failure is bad. It is not really a bug.
-Andi
next parent reply other threads:[~2006-02-08 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1139342419.6065.8.camel@mulgrave.il.steeleye.com.suse.lists.linux.kernel>
2006-02-08 8:06 ` Andi Kleen [this message]
2006-02-08 8:18 ` [PATCH] add execute_in_process_context() API Andrew Morton
2006-02-08 8:50 ` Andi Kleen
2006-02-08 15:15 ` James Bottomley
2006-02-08 15:18 ` Andi Kleen
2006-02-08 15:57 ` James Bottomley
2006-02-08 16:07 ` Andi Kleen
2006-02-08 15:30 ` Tejun
2006-02-08 15:36 ` James Bottomley
2006-02-07 20:00 James Bottomley
2006-02-07 20:26 ` Dave Jones
2006-02-07 20:34 ` Andrew Morton
2006-02-08 12:51 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p737j86l1es.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.