From: Andi Kleen <andi@firstfloor.org>
To: Dave Jones <davej@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Josh Triplett <josh@freedesktop.org>,
linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: sparse -Wptr-subtraction-blows: still needed?
Date: 02 May 2007 15:03:59 +0200 [thread overview]
Message-ID: <p73abwnxtq8.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070502024242.GC6935@redhat.com>
Dave Jones <davej@redhat.com> writes:
>
> #define __page_to_pfn(page) ((unsigned long)((page) - mem_map) + \
> ARCH_PFN_OFFSET)
>
> looks like the other two variants of __page_to_pfn also use similar arithmatic.
No way around this. The only way to turn a page into a pfn is to do
a constant division. Should be fairly cheap here though.
-Andi (who thinks the sparse warning is dumb; better to look at oprofiles
of hot paths)
prev parent reply other threads:[~2007-05-02 12:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 21:08 sparse -Wptr-subtraction-blows: still needed? Josh Triplett
2007-05-01 21:43 ` Linus Torvalds
2007-05-01 23:59 ` Josh Triplett
2007-05-02 0:24 ` Linus Torvalds
2007-05-02 0:35 ` Al Viro
2007-05-02 12:02 ` Alan Cox
2007-05-02 13:19 ` Andi Kleen
2007-05-02 0:26 ` Al Viro
2007-05-02 0:02 ` Al Viro
2007-05-02 2:42 ` Dave Jones
2007-05-02 13:03 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73abwnxtq8.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=josh@freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.