All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Scheduler Profiling - Use Immediate Values
Date: 08 Sep 2007 18:12:27 +0200	[thread overview]
Message-ID: <p73bqcd9lw4.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070906200537.GA5999@Krystal>

Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> writes:
>  
> -	profile_hit(SCHED_PROFILING, __builtin_return_address(0));
> +	immediate_if (&sched_profiling)

I must say I really dislike immediate_if(). You complained earlier
that something breaks coloring, but adding such macros will definitely
break a lot of editors (especially if you use it without {} like here)

It would be much nicer and readable to just use if 
(unlikely(immediate_read(&x)) or if you prefer to hide the unlikely
if (immediate_bool_test(&x)) with an implicit unlikely().

-Andi

  parent reply	other threads:[~2007-09-08 16:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-06 20:05 [PATCH] Scheduler Profiling - Use Immediate Values Mathieu Desnoyers
2007-09-06 20:55 ` Randy Dunlap
2007-09-07 12:14   ` Mathieu Desnoyers
2007-09-08 16:12 ` Andi Kleen [this message]
2007-09-12 14:19   ` Mathieu Desnoyers
2007-09-12 14:32     ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2007-12-06  2:14 Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73bqcd9lw4.fsf@bingen.suse.de \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.