From: Andi Kleen <ak@suse.de>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>,
ebiederm@xmission.com, pj@sgi.com,
saito.tadashi@soft.fujitsu.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] ps command race fix take2 [1/4] list token
Date: 22 Aug 2006 13:06:34 +0200 [thread overview]
Message-ID: <p73bqqd81xh.fsf@verdi.suse.de> (raw)
In-Reply-To: <20060822173904.5f8f6e0f.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:
>
> listtoken , a helper for walking a list by intermittent access.
>
> When we walk a list intermittently and the list is being modified at the
> same time, it's hard to remember our position in it.
>
> With this list token, a user can remember where he is reading by inserting
> a token in the list.
I think the header/code needs much more comments so that other people
can still make sense of it later. Even with the commit log it's not
quite clear how it works.
Also locking needs to be explained. I suppose only one user is allowed
to use a token at one time?
But overall it's a good idea to have a generic facility like this.
I suppose it will be a more common problem in the future.
-Andi
next prev parent reply other threads:[~2006-08-22 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 8:39 [RFC][PATCH] ps command race fix take2 [1/4] list token KAMEZAWA Hiroyuki
2006-08-22 11:06 ` Andi Kleen [this message]
2006-08-22 11:23 ` KAMEZAWA Hiroyuki
2006-08-22 16:56 ` Eric W. Biederman
2006-08-22 22:22 ` KAMEZAWA Hiroyuki
2006-08-23 6:11 ` Eric W. Biederman
2006-08-23 8:33 ` KAMEZAWA Hiroyuki
2006-08-23 11:35 ` Eric W. Biederman
2006-08-23 12:46 ` KAMEZAWA Hiroyuki
2006-08-23 9:55 ` Avi Kivity
2006-08-23 12:12 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73bqqd81xh.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=saito.tadashi@soft.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.