From: Andi Kleen <andi@firstfloor.org>
To: Bruce Rogers <brogers@novell.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Fix performance problems with mprotect()
Date: Mon, 07 Jan 2008 16:18:59 +0100 [thread overview]
Message-ID: <p73d4sdsly4.fsf@bingen.suse.de> (raw)
In-Reply-To: <477EAC09.5C6B.0048.1@novell.com> (Bruce Rogers's message of "Fri\, 04 Jan 2008 21\:49\:41 -0700")
"Bruce Rogers" <brogers@novell.com> writes:
> +
> + /* Allowed to change in Accessed/Dirty flags only. */
> + BUG_ON((t ^ old) & ~(intpte_t)(_PAGE_ACCESSED|_PAGE_DIRTY));
Are you sure that BUG_ON can't be triggered from the hypercall?
It should error out in this case I think.
-Andi
next prev parent reply other threads:[~2008-01-07 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 4:49 [PATCH] Fix performance problems with mprotect() Bruce Rogers
2008-01-05 13:35 ` John Levon
2008-01-06 23:22 ` Keir Fraser
2008-01-07 15:03 ` Jan Beulich
2008-01-07 17:05 ` Bruce Rogers
2008-01-07 17:45 ` Keir Fraser
2008-01-07 18:03 ` Bruce Rogers
2008-01-07 15:18 ` Andi Kleen [this message]
2008-01-07 16:16 ` Bruce Rogers
2008-01-07 17:35 ` Keir Fraser
2008-01-19 0:03 ` Bruce Rogers
-- strict thread matches above, loose matches on Subject: below --
2008-01-05 15:05 Bruce Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73d4sdsly4.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=brogers@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.