From: Andi Kleen <andi@firstfloor.org>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: nagar@watson.ibm.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Optimize struct task_delay_info
Date: 11 Jul 2007 14:27:11 +0200 [thread overview]
Message-ID: <p73d4yzyvkw.fsf@bingen.suse.de> (raw)
In-Reply-To: <1184138034.3068.51.camel@ymzhang>
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com> writes:
> replace them;
> 2) Delete lock. The change to the protected data has no nested cases.
> In addition, the result is for performance data collection, so it’s
> unnecessary to add such lock.
Not sure that's a good idea. People expect their performance counts
to be accurate too. You could possibly use atomics though, but
when there are multiple counters updated the spinlock will be likely
faster.
-Andi
next prev parent reply other threads:[~2007-07-11 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 7:13 [PATCH] Optimize struct task_delay_info Zhang, Yanmin
2007-07-11 11:46 ` Balbir Singh
2007-07-18 4:30 ` Zhang, Yanmin
2007-07-23 1:08 ` Zhang, Yanmin
2007-07-11 12:27 ` Andi Kleen [this message]
2007-07-12 8:37 ` Zhang, Yanmin
2007-07-12 18:21 ` Frank Ch. Eigler
2007-07-13 1:52 ` Zhang, Yanmin
2007-07-23 5:14 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73d4yzyvkw.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nagar@watson.ibm.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.