From: Andi Kleen <andi@firstfloor.org>
To: miaox@cn.fujitsu.com
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] time: add an offline-cpu check in add_timer_on()
Date: Fri, 14 Dec 2007 11:56:44 +0100 [thread overview]
Message-ID: <p73lk7xfssz.fsf@bingen.suse.de> (raw)
In-Reply-To: <47625B94.50105@cn.fujitsu.com> (Miao Xie's message of "Fri\, 14 Dec 2007 18\:31\:48 +0800")
Miao Xie <miaox@cn.fujitsu.com> writes:
> Hi everyone,
> I think we need a check in the function add_timer_on() to avoid adding a
> timer into the timer list of an offline cpu.
>
> This patch fixes this problem in add_timer_on().
No it doesn't -- it will just crash if a caller does that. If it's a real
problem then you either need to fix the callers or change add_timer_on()
to transparently put it onto another CPU.
I don't think it's a real problem though because CPU offlining does
a stop machine and that should take care of most such races.
-Andi
next prev parent reply other threads:[~2007-12-14 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 10:31 [PATCH] time: add an offline-cpu check in add_timer_on() Miao Xie
2007-12-14 10:56 ` Andi Kleen [this message]
2007-12-14 11:05 ` Thomas Gleixner
2007-12-14 11:03 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73lk7xfssz.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.