From: Andi Kleen <ak@suse.de>
To: Akinobu Mita <mita@miraclelinux.com>
Cc: akpm@osdl.org, okuji@enbug.org, Jens Axboe <axboe@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 4/5] fail-injection capability for disk IO
Date: 23 Aug 2006 14:07:10 +0200 [thread overview]
Message-ID: <p73lkpf64gh.fsf@verdi.suse.de> (raw)
In-Reply-To: <20060823113317.722640313@localhost.localdomain>
Akinobu Mita <mita@miraclelinux.com> writes:
> * @bio: The bio describing the location in memory and on the device.
> @@ -3077,6 +3093,9 @@ end_io:
> if (unlikely(test_bit(QUEUE_FLAG_DEAD, &q->queue_flags)))
> goto end_io;
>
> + if (should_fail(fail_make_request, bio->bi_size))
> + goto end_io;
AFAIK it is reasonably easy to write stacking block drivers.
I think I would prefer a stackable driver instead of this hook.
-Andi
next prev parent reply other threads:[~2006-08-23 12:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 11:32 [patch 0/5] RFC: fault-injection capabilities Akinobu Mita
2006-08-23 11:32 ` [patch 1/5] fail-injection library Akinobu Mita
2006-08-23 12:09 ` Andi Kleen
2006-08-23 11:32 ` [patch 2/5] fail-injection capability for kmalloc Akinobu Mita
2006-08-23 11:32 ` [patch 3/5] fail-injection capability for alloc_pages() Akinobu Mita
2006-08-23 11:32 ` [patch 4/5] fail-injection capability for disk IO Akinobu Mita
2006-08-23 12:03 ` Jens Axboe
2006-08-23 17:27 ` Andrew Morton
2006-08-23 18:01 ` Jens Axboe
2006-08-23 18:16 ` Ric Wheeler
2006-08-23 18:26 ` Jens Axboe
2006-08-23 18:22 ` Hans Reiser
2006-08-23 12:07 ` Andi Kleen [this message]
2006-08-23 12:10 ` Jens Axboe
2006-08-23 19:34 ` Mario 'BitKoenig' Holbe
2006-08-23 19:42 ` Ric Wheeler
2006-08-23 11:32 ` [patch 5/5] debugfs entries for configuration Akinobu Mita
2006-08-23 12:06 ` [patch 0/5] RFC: fault-injection capabilities Andi Kleen
2006-08-23 14:18 ` Alexey Dobriyan
2006-08-24 18:41 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73lkpf64gh.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mita@miraclelinux.com \
--cc=okuji@enbug.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.