From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@suse.de>
Subject: Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen
Date: 15 May 2006 18:27:55 +0200
Message-ID: <p73lkt35k38.fsf@bragg.suse.de>
References: <20060501215648.GU16776@us.ibm.com>
	<28761a939c7a83af7fa1c34e8700025f@cl.cam.ac.uk>
	<20060512151223.GD16876@us.ibm.com>
	<095d150f0370d6aeb03f23253d0ccaac@cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <095d150f0370d6aeb03f23253d0ccaac@cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com, Ryan Grimm <grimm@us.ibm.com>
List-Id: xen-devel@lists.xenproject.org

Keir Fraser <Keir.Fraser@cl.cam.ac.uk> writes:

>   1. You re-indented. Normally a good thing but not for copies of
> Linux source files. Please edit them and maintain them in Linux style
> (inc. hard tabs) as it makes it easier to sync with Linux updates.

What Linux updates? The i386 NUMA support is basically dead and
bitrots slowly (except perhaps on NUMAQ) Every half a year someone
uses it and finds it doesn't work, maybe even fixes it and then it
breaks shortly after again. That's because it isn't used and tested in
any significant way. No distribution I'm aware of uses it either.

If you want maintained NUMA it would be much better to base on the x86-64
NUMA code.

-Andi