From: Andi Kleen <ak@suse.de>
To: "Bryan O'Sullivan" <bos@serpentine.com>
Cc: davem@davemloft.net, arjan@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add memcpy_cachebypass, a copy routine that tries to keep cache pressure down
Date: 12 Jul 2006 18:15:45 +0200 [thread overview]
Message-ID: <p73odvun6j2.fsf@verdi.suse.de> (raw)
In-Reply-To: <da0cd816c4cb37c4376b.1152651055@localhost.localdomain>
Bryan O'Sullivan <bos@serpentine.com> writes:
> + * memcpy_cachebypass - memcpy-compatible copy routine, using streaming loads
> + * @dest: destination address
> + * @src: source address (will not be cached)
> + * @count: number of bytes to copy
> + *
> + * Use streaming loads and normal stores for a special-case copy where
> + * we know we won't be reading the source again, but will be reading the
> + * destination again soon.
> + */
For what CPU did you optimize that function? Comment missing for that.
Also the comment should state that you're caching the target.
Also I trust you ran it through a comprehensive memcpy-all-cases tester?
-Andi
prev parent reply other threads:[~2006-07-12 16:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-11 20:50 [PATCH] Add memcpy_cachebypass, a copy routine that tries to keep cache pressure down Bryan O'Sullivan
2006-07-11 20:56 ` Arjan van de Ven
2006-07-11 20:57 ` David Miller
2006-07-11 21:30 ` Bryan O'Sullivan
2006-07-11 21:57 ` David Miller
2006-07-11 22:05 ` Bryan O'Sullivan
2006-07-11 22:08 ` David Miller
2006-07-12 8:04 ` Christoph Hellwig
2006-07-11 21:09 ` Randy.Dunlap
2006-07-11 21:35 ` Bryan O'Sullivan
2006-07-11 22:48 ` Randy.Dunlap
2006-07-12 16:15 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73odvun6j2.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=arjan@infradead.org \
--cc=bos@serpentine.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.