From: Andi Kleen <ak@suse.de>
To: Joachim Fritschi <jfritschi@freenet.de>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/2] Twofish cipher x86_64-asm optimized
Date: 07 May 2006 12:38:30 +0200 [thread overview]
Message-ID: <p73odya3ys9.fsf@bragg.suse.de> (raw)
In-Reply-To: <200605071157.03362.jfritschi@freenet.de>
Joachim Fritschi <jfritschi@freenet.de> writes:
>
> Testing:
> -----------
> The code passed the kernel test module and passed automated tests on a
> dm-crypt volume reading/writing large files with alternating modules ( c /
> assembler ) and comparing results. It is also running on my workstation for
> over a week now.
It would be good if you could run some random input encrypt/decrypt tests
comparing the C reference version with yours. We have had bad luck
with assembler functions not quite implementing the same cipher
in the past.
>
> Please have a look, try, improve and criticise.
Is it really needed to duplicate all the C code and tables - can't that
be shared with the portable C code?
Also don't make it a separate config - it should just be a replacement
on x86-64.
-Andi
next prev parent reply other threads:[~2006-05-07 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-07 9:57 [RFC][PATCH 2/2] Twofish cipher x86_64-asm optimized Joachim Fritschi
2006-05-07 10:38 ` Andi Kleen [this message]
2006-05-07 12:33 ` Herbert Xu
2006-05-07 13:33 ` Joachim Fritschi
2006-05-07 12:47 ` Joachim Fritschi
2006-05-07 20:49 ` Joachim Fritschi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73odya3ys9.fsf@bragg.suse.de \
--to=ak@suse.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jfritschi@freenet.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.