From: Andi Kleen <ak@suse.de>
To: Alex Tomas <bzzz@tmi.comex.ru>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
ext2-devel@lists.sourceforge.net
Subject: Re: [PATCH] minor optimization for EXT3
Date: 10 Jul 2003 14:43:07 +0200 [thread overview]
Message-ID: <p73of02pn6s.fsf@oldwotan.suse.de> (raw)
In-Reply-To: <87y8z6gyt3.fsf@gw.home.net.suse.lists.linux.kernel>
Alex Tomas <bzzz@tmi.comex.ru> writes:
> + if (i == start + inodes_per_buffer) {
> + /* all inodes (but our) are free. so, we skip I/O */
Won't this make undeletion a lot harder? Deleted inodes will now be trashed
at will, so you cannot use their contents anymore.
Also dtimes in free inodes can be now lost, can't they? Did you check
if that causes problems in fsck? [my understanding was that ext2/3 fsck relies on the
dtime to make some heuristics when recovering files work better]
Maybe it should be an mount option so that users can trade performance against
better recoverability.
-Andi
next parent reply other threads:[~2003-07-10 12:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87smpeigio.fsf@gw.home.net.suse.lists.linux.kernel>
[not found] ` <20030710042016.1b12113b.akpm@osdl.org.suse.lists.linux.kernel>
[not found] ` <87y8z6gyt3.fsf@gw.home.net.suse.lists.linux.kernel>
2003-07-10 12:43 ` Andi Kleen [this message]
2003-07-10 16:51 ` [PATCH] minor optimization for EXT3 Alex Tomas
2003-07-10 12:55 ` Andi Kleen
2003-07-10 14:49 Alex Tomas
2003-07-10 11:20 ` Andrew Morton
2003-07-10 15:33 ` bzzz
2003-07-10 15:51 ` Andrew Morton
2003-07-10 20:46 ` Alex Tomas
2003-07-10 17:01 ` Andrew Morton
2003-07-10 21:09 ` Alex Tomas
2003-07-10 19:14 ` Andreas Dilger
2003-07-10 15:56 ` Alex Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73of02pn6s.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bzzz@tmi.comex.ru \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.