From: Andi Kleen <ak@suse.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BLOCK] bh: Ensure bh fits within a page
Date: 01 Aug 2006 21:33:54 +0200 [thread overview]
Message-ID: <p73psfkz1wd.fsf@verdi.suse.de> (raw)
In-Reply-To: <20060801030443.GA2221@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> writes:
> --
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 71649ef..b998f08 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2790,6 +2790,7 @@ int submit_bh(int rw, struct buffer_head
> BUG_ON(!buffer_locked(bh));
> BUG_ON(!buffer_mapped(bh));
> BUG_ON(!bh->b_end_io);
> + WARN_ON(bh_offset(bh) + bh->b_size > PAGE_SIZE);
What happens when someone implements direct large page IO?
-Andi
next prev parent reply other threads:[~2006-08-01 19:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 3:04 [BLOCK] bh: Ensure bh fits within a page Herbert Xu
2006-08-01 4:04 ` Andrew Morton
2006-08-01 5:02 ` Herbert Xu
2006-08-01 5:54 ` Andrew Morton
2006-08-01 11:06 ` Herbert Xu
2006-08-01 14:45 ` Andrew Morton
2006-08-01 17:36 ` Christoph Lameter
2006-08-01 19:08 ` Pekka Enberg
2006-08-01 19:08 ` Steven Rostedt
2006-08-01 19:10 ` Christoph Lameter
2006-08-01 19:35 ` Steven Rostedt
2006-08-01 19:55 ` Christoph Lameter
2006-08-01 7:23 ` Jens Axboe
2006-08-01 23:30 ` Herbert Xu
2006-08-01 23:32 ` Herbert Xu
2006-08-02 6:23 ` Jens Axboe
2006-08-01 23:44 ` Andrew Morton
2006-08-17 23:14 ` Badari Pulavarty
2006-08-18 2:53 ` Herbert Xu
2006-08-01 19:33 ` Andi Kleen [this message]
2006-08-01 22:09 ` Herbert Xu
2006-08-02 11:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73psfkz1wd.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.