From: Andi Kleen <andi@firstfloor.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Review: Concurrent Multi-File Data Streams
Date: 12 May 2007 20:46:19 +0200 [thread overview]
Message-ID: <p73sla1ev7o.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070511003606.GB85884050@sgi.com>
David Chinner <dgc@sgi.com> writes:
>
> The following patch survives XFSQA with timeouts set to minimum,
> default, 500s and maximum. The patch has not had a great
> deal of low memory testing, and the object cache may need a shrinker
> interface to work in low memory conditions.
>
> Comments?
It seems to be an optimization for a relatively small number of streams. When you
do a large number on average you should get similar readahead benefits
from round robing the streams over some AGs vs keeping it in a single AG,
right?
The fallback to AG 0 if nstreams>AGs seems pretty lousy. Wouldn't it be better
to do the normal XFS allocation algorithm then? I think right now it will
go into low space mode in this case, which might give worse results.
Also centisecs is a really ugly unit whose use should be probably not propagated.
-Andi
next prev parent reply other threads:[~2007-05-12 17:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 0:36 Review: Concurrent Multi-File Data Streams David Chinner
2007-05-12 18:46 ` Andi Kleen [this message]
2007-05-13 3:08 ` Eric Sandeen
2007-05-14 5:35 ` Review: Concurrent Multi-File Data Streams - centisecs Timothy Shimmin
[not found] ` <000001c79544$44076ac0$0501010a@DCHATTERTONLAPTOP>
2007-05-14 22:39 ` Review: Concurrent Multi-File Data Streams Andi Kleen
2007-05-15 0:05 ` David Chinner
2007-05-15 0:15 ` David Chatterton
2007-05-13 20:59 ` Christoph Hellwig
2007-05-15 6:23 ` David Chinner
2007-05-15 9:23 ` Christoph Hellwig
2007-09-20 1:31 ` Hxsrmeng
2007-09-21 9:13 ` Leon Kolchinsky
2007-09-21 12:55 ` David Chinner
[not found] ` <1190399077.3795.86.camel@localhost.localdomain>
2007-09-23 7:45 ` David Chinner
2007-09-23 15:47 ` Ming Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73sla1ev7o.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.