From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] clean up CFLAGS
Date: 10 Mar 2006 15:50:00 +0100
Message-ID: <p73slpquzfr.fsf@verdi.suse.de>
References: <441022BC.D169.003C.0@novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <441022BC.D169.003C.0@novell.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Charles Coffing <ccoffing@novell.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

"Charles Coffing" <ccoffing@novell.com> writes:

> This patch cleans up the usage of CFLAGS.  This is nice for packagers,
> who would like to control the base compilation flags from a central
> place.
> 
> I've put some default CFLAGS (-Wall -O3) 

Are you sure -O3 is a good idea? In my experience it just bloats 
.text for most projects because of its aggressive inlining. I would
use -O2.

-Andi