From: Andi Kleen <andi@firstfloor.org>
To: mingo@elte.hu
Cc: hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [5/7] Remove CONFIG_X86_TSC for 32bit II
Date: Fri, 18 Jan 2008 22:05:08 +0100 [thread overview]
Message-ID: <p73tzlaalq3.fsf_-_@bingen.suse.de> (raw)
In-Reply-To: <20080118172721.96C8B14AAE@wotan.suse.de> (Andi Kleen's message of "Fri\, 18 Jan 2008 18\:27\:21 +0100 \(CET\)")
Andi Kleen <ak@suse.de> writes:
> The config option protects so little code that it is fairly pointless.
> Also a lot of its code was related to itself only (as in panicing without
> TSC). And TSC less CPUs are completely handled at runtime anyways.
>
> This makes 32bit behaviour match x86-64.
>
> I also removed an #if defined(CONFIG_X86_GENERIC) in get_cycles. Not sure
> what that was good for, it didn't make any sense.
Hmm, during further testing i found that the patch causes boot failures
in some configuration. I withdraw this one for now.
The other patches in the series are independent and should be still
considered for merging.
-Andi
next prev parent reply other threads:[~2008-01-18 21:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 17:27 [PATCH] [0/7] Add noclflush option and related cleanup Andi Kleen
2008-01-18 17:27 ` [PATCH] [1/7] Add frame work to disable CPUID bits on the command line Andi Kleen
2008-01-18 17:27 ` [PATCH] [2/7] Convert some existing cpuid disable options to new generic bitmap Andi Kleen
2008-01-18 17:27 ` [PATCH] [3/7] Don't disable RDTSC in userland for 32bit notsc Andi Kleen
2008-01-18 17:27 ` [PATCH] [4/7] Convert TSC disabling to generic cpuid disable bitmap Andi Kleen
2008-01-19 18:15 ` Ian Campbell
2008-01-19 18:57 ` Andi Kleen
2008-01-19 22:29 ` Ian Campbell
2008-01-19 18:18 ` Ian Campbell
2008-01-18 17:27 ` [PATCH] [5/7] Remove CONFIG_X86_TSC for 32bit Andi Kleen
2008-01-18 21:05 ` Andi Kleen [this message]
2008-01-18 22:06 ` [PATCH] [5/7] Remove CONFIG_X86_TSC for 32bit II Ingo Molnar
2008-01-18 17:27 ` [PATCH] [6/7] Add noclflush option Andi Kleen
2008-01-18 17:27 ` [PATCH] [7/7] Add generic clearcpuid=... option Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73tzlaalq3.fsf_-_@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.