From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1IkJIK-0005my-9z for user-mode-linux-devel@lists.sourceforge.net; Tue, 23 Oct 2007 05:55:40 -0700 Received: from ns2.suse.de ([195.135.220.15] helo=mx2.suse.de) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IkJII-0007vl-Qz for user-mode-linux-devel@lists.sourceforge.net; Tue, 23 Oct 2007 05:55:40 -0700 From: Andi Kleen References: <20071022065202.GI2998@hacking> <20071022065943.GC10864@uranus.ravnborg.org> <20071022074823.GJ2998@hacking> <20071022113600.GA8181@ftp.linux.org.uk> <20071022122504.GL2998@hacking> <20071022124322.GB8181@ftp.linux.org.uk> <20071022124551.GA7438@elte.hu> <471D2ECC.6090209@goop.org> <20071022231927.GA30814@elte.hu> <471D389E.40609@goop.org> <20071023084546.GA17007@elte.hu> Date: Tue, 23 Oct 2007 14:55:30 +0200 In-Reply-To: <20071023084546.GA17007@elte.hu> (Ingo Molnar's message of "Tue\, 23 Oct 2007 10\:45\:46 +0200") Message-ID: MIME-Version: 1.0 Subject: Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final. List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Ingo Molnar Cc: Jeremy Fitzhardinge , user-mode-linux-devel@lists.sourceforge.net, Jeff Dike , Paolo Giarrusso , linux-kernel@vger.kernel.org, Nix , Rob Landley , Al Viro , WANG Cong , Sam Ravnborg Ingo Molnar writes: > > the 'fastcall removal' changes to paravirt.c were over-eager: they > removed fastcall annotations from functions that are (or might be) > implemented in assembly. So if someone changes the compiler model, > such as -pg which disables regparm, the kernel breaks in nasty ways. It would be probably better to just not disable -mregparms. I don't think the compiler forces this. And e.g. on x86-64 regparms & -pg work just fine, why should it not on i386? > so this patch adds back fastcall annotations. This serves as > documentation for assembly calling-convention dependencies as > well. You should rename it then to "asmcall" or something. -Andi ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753270AbXJWMzq (ORCPT ); Tue, 23 Oct 2007 08:55:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751557AbXJWMzh (ORCPT ); Tue, 23 Oct 2007 08:55:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54143 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753109AbXJWMzg (ORCPT ); Tue, 23 Oct 2007 08:55:36 -0400 To: Ingo Molnar Cc: Jeremy Fitzhardinge , Al Viro , WANG Cong , Sam Ravnborg , Nix , Jeff Dike , Paolo Giarrusso , user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Rob Landley Subject: Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final. From: Andi Kleen References: <20071022065202.GI2998@hacking> <20071022065943.GC10864@uranus.ravnborg.org> <20071022074823.GJ2998@hacking> <20071022113600.GA8181@ftp.linux.org.uk> <20071022122504.GL2998@hacking> <20071022124322.GB8181@ftp.linux.org.uk> <20071022124551.GA7438@elte.hu> <471D2ECC.6090209@goop.org> <20071022231927.GA30814@elte.hu> <471D389E.40609@goop.org> <20071023084546.GA17007@elte.hu> Date: Tue, 23 Oct 2007 14:55:30 +0200 In-Reply-To: <20071023084546.GA17007@elte.hu> (Ingo Molnar's message of "Tue\, 23 Oct 2007 10\:45\:46 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar writes: > > the 'fastcall removal' changes to paravirt.c were over-eager: they > removed fastcall annotations from functions that are (or might be) > implemented in assembly. So if someone changes the compiler model, > such as -pg which disables regparm, the kernel breaks in nasty ways. It would be probably better to just not disable -mregparms. I don't think the compiler forces this. And e.g. on x86-64 regparms & -pg work just fine, why should it not on i386? > so this patch adds back fastcall annotations. This serves as > documentation for assembly calling-convention dependencies as > well. You should rename it then to "asmcall" or something. -Andi