All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: sri@us.ibm.com, rick.jones2@hp.com, netdev@vger.kernel.org
Subject: Re: why does tcp_v[46]_conn_request not inc MIB stats
Date: 18 Sep 2007 13:07:39 +0200	[thread overview]
Message-ID: <p73wsuow7t0.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070914.201152.35026256.davem@davemloft.net>

David Miller <davem@davemloft.net> writes:

> This is limiting embryonic mini-socket creation.  The listen overflow
> should only increment when the 3-way handshake completion is aborted
> because the listening socket limit is exceeded, which is entirely
> different from the embryonic limit.

That's true, but I think Rick has a point in that there should 
be some sort of (different) counter counting this.  In general
I believe every point in the stack who drops a packet should
have a statistics counter so that it can be later diagnosed.

Rick, the best way to get such a counter in is to just send a patch,
don't ask for it.

-Andi

  reply	other threads:[~2007-09-18 11:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-10 18:42 why does tcp_v[46]_conn_request not inc MIB stats Rick Jones
2007-09-10 21:54 ` Sridhar Samudrala
2007-09-10 22:22   ` Rick Jones
2007-09-15  3:11   ` David Miller
2007-09-18 11:07     ` Andi Kleen [this message]
2007-09-18 17:14       ` Rick Jones
2007-09-15  3:10 ` David Miller
2007-09-17 18:13   ` Rick Jones
2007-09-17 18:26     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73wsuow7t0.fsf@bingen.suse.de \
    --to=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    --cc=sri@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.