From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262073AbVHFLiC (ORCPT ); Sat, 6 Aug 2005 07:38:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262334AbVHFLiC (ORCPT ); Sat, 6 Aug 2005 07:38:02 -0400 Received: from cantor.suse.de ([195.135.220.2]:45748 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S262073AbVHFLhc (ORCPT ); Sat, 6 Aug 2005 07:37:32 -0400 To: Zachary Amsden Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] 8/8 Create MMU 2/3 level accessors in the sub-arch layer (i386) References: <42F46558.9010202@vmware.com.suse.lists.linux.kernel> From: Andi Kleen Date: 06 Aug 2005 13:37:31 +0200 In-Reply-To: <42F46558.9010202@vmware.com.suse.lists.linux.kernel> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Zachary Amsden writes: > i386 Transparent paravirtualization sub-arch patch #8. > > Transparent paravirtualization support for MMU operations. > > All operations which update live page table entries have been moved to the > sub-architecture layer. Unfortunately, this required yet another parallel set > of pgtable-Nlevel-ops.h files, but this avoids the ugliness of having to use > #ifdef's all of the code. > > This is pure code motion. Anything else would be a bug. I think that patch is really ugly - it makes hacking VM on i386 even more painful than it already is because the convolutes the file structure even more. Hope it is not applied. -Andi