From: Andi Kleen <andi@firstfloor.org>
To: Oliver Neukum <oliver@neukum.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()
Date: Wed, 30 Jan 2008 09:27:41 +0100 [thread overview]
Message-ID: <p73zlun67lu.fsf@bingen.suse.de> (raw)
In-Reply-To: <200801300925.12397.oliver@neukum.org> (Oliver Neukum's message of "Wed\, 30 Jan 2008 09\:25\:12 +0100")
Oliver Neukum <oliver@neukum.org> writes:
> Am Mittwoch, 30. Januar 2008 09:01:10 schrieb Andi Kleen:
>>
>> gcc does not generate different code for return foo vs bar = foo; goto x;
>> x: return bar; So convert it all to direct returns for better readability.
>
> Now suppose somebody needs to change locking. He'll have to convert
> it back.
Please take a look at the overall /proc/net/tcp logic. Any locking
change will be a major change to the code flow of the whole family
of funtions.
-Andi
next prev parent reply other threads:[~2008-01-30 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 8:01 [PATCH] [1/2] Skip empty hash buckets faster in /proc/net/tcp Andi Kleen
2008-01-30 8:01 ` [PATCH] [2/2] Remove some unnecessary gotos in established_get_first() Andi Kleen
2008-01-30 8:25 ` Oliver Neukum
2008-01-30 8:27 ` Andi Kleen [this message]
2008-01-30 13:46 ` David Miller
2008-01-30 17:03 ` [PATCH] [1/2] Skip empty hash buckets faster in /proc/net/tcp Roland Dreier
2008-01-30 17:32 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73zlun67lu.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.