All of lore.kernel.org
 help / color / mirror / Atom feed
From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: [BUG?] btrfs scrub -d doesn't scan all devices
Date: Mon, 28 Dec 2015 03:16:41 +0000 (UTC)	[thread overview]
Message-ID: <pan$5b580$699280fb$ded9f44b$b00968c3@cox.net> (raw)
In-Reply-To: 1451265688.6320.22.camel@scientia.net

Christoph Anton Mitterer posted on Mon, 28 Dec 2015 02:21:28 +0100 as
excerpted:

> On Sun, 2015-12-27 at 07:22 +0000, Duncan wrote:
>> I'd call that NOTABUG.  As the btrfs-scrub manpage suggests:
>> 
>> * When you point scrub at a mountpoint, it scrubs all devices composing
>> that filesystem.

> Uhm,.. mine doesn't contain this,... neither do those of the master or
> devel branches from David's repo... or am I just blind?

I see that Chris Murphy just filed a bug on it with the particulars, but 
just to clear this up...

That's my paraphrase of what it says, thus the "suggests", but I do 
specifically quote, with "the manpage specifically says" and quote marks, 
so it's pretty hard to miss, which I /thought/, along with "suggests", 
should make it clear that I was NOT specifically quoting the manpage in 
the bullet-point.

Apparently not...

> Actually it says:
>>DESCRIPTION
>>       btrfs scrub is used to scrub a btrfs filesystem, which
>>       will read all data from all disks and verify checksums.

Look under scrub start...  as you did in a followup...

>> Since /dev/disk/by-*/* are symlinks to various block-device nodes, it
>> follows that if you point scrub at them, only the device pointed at is
>> scrubbed, exactly as one might expect based on the manpage.

> Sure... that was clear... but I have another manpage than yours...
> perhaps some distro specific patch?

No, just both a slightly more specific part of the manpage, under scrub 
start, and a mistake in believing "suggests" implies or explicitly 
specifies a direct quote, even when a direct quote is later actually 
made, complete with quotation marks and "the manpage specifically says" 
attribution.

btrfs-progs v4.3.1, if it matters.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


      parent reply	other threads:[~2015-12-28  3:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-27  3:38 [BUG?] btrfs scrub -d doesn't scan all devices Christoph Anton Mitterer
2015-12-27  7:22 ` Duncan
2015-12-28  1:21   ` Christoph Anton Mitterer
2015-12-28  1:25     ` Christoph Anton Mitterer
2015-12-28  1:36       ` Chris Murphy
2015-12-28  3:30       ` Duncan
2015-12-28  4:37         ` Christoph Anton Mitterer
2015-12-28  1:27     ` Chris Murphy
2015-12-28  3:16     ` Duncan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='pan$5b580$699280fb$ded9f44b$b00968c3@cox.net' \
    --to=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.