From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: have restore set atime/mtime
Date: Fri, 17 Apr 2015 01:09:06 +0000 (UTC) [thread overview]
Message-ID: <pan$9774f$be540432$25bcbd9d$e84db021@cox.net> (raw)
In-Reply-To: 553046DA.7090809@gmail.com
Dan Merillat posted on Thu, 16 Apr 2015 19:33:46 -0400 as excerpted:
> The inode is already found, use the data and make restore friendlier.
Unless things have changed recently, restore doesn't even restore user/
group ownership, let alone permissions. IOW, atime/mtime are the least
of the problem (particularly if people are running noatime as is
recommended, unless you really need it for some reason).
It simply creates the files it restores as the owner/group it is run as
(normally root), using standard umask rules, I believe.
So if you're going to have it start restoring metadata at all, might as
well have it do ownership/perms too, if it can. Otherwise atime/mtime
are hardly worth bothering with.
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
next prev parent reply other threads:[~2015-04-17 1:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 23:33 [PATCH] btrfs-progs: have restore set atime/mtime Dan Merillat
2015-04-16 23:43 ` Dan Merillat
2015-04-17 1:09 ` Duncan [this message]
2015-04-17 2:19 ` Dan Merillat
[not found] ` <GqKV1q00y3iShQZ01qKkzm>
2015-04-17 3:24 ` Duncan
[not found] ` <CADfjVrg=hZNE1x4F3H05Ds_H9WDBjuY2ZPPixuxiUanAd2mOHw@mail.gmail.com>
2015-04-17 12:32 ` Dan Merillat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='pan$9774f$be540432$25bcbd9d$e84db021@cox.net' \
--to=1i5t5.duncan@cox.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.