From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 1/3] Output Virtual Block Device requests information to /proc/xen/vbd Date: Wed, 21 Jun 2006 09:33:45 -0500 Message-ID: References: <004501c69523$bbd0b8d0$2c87380a@ad.spf.cl.nec.co.jp> <449931CD.1050806@us.ibm.com> <7b0e62909852d221b9c21f3519228feb@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, 21 Jun 2006 13:30:34 +0100, Keir Fraser wrote: > > On 21 Jun 2006, at 12:47, Anthony Liguori wrote: > >>> In my subjective, currently, procfs is used for representing dynamic >>> information such as statistical data, and sysfs is used for >>> representing >>> statical information such as module parameters. >> >> /proc is for process information. This stuff definitely belongs in >> sysfs. It's analogous to /sys/class/net/eth0/statistics/. > > Yes. The patchset looks good and is obviously useful -- we'd like to > apply it if this gets fixed. Agreed! It's a very common feature request so it'll be great to get this in the tree. This information is sort of available in /sys/block//stat but it's not terribly reliable in my experience (it's always zero's for loop devices IIRC). These patches are missing Signed-Off-By lines too btw. When you resubmit, make sure to include those. Thanks, Anthony Liguori > -- Keir