From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JNrqo-0003Qj-6v for mharc-grub-devel@gnu.org; Sat, 09 Feb 2008 10:42:46 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JNrqm-0003Pe-4m for grub-devel@gnu.org; Sat, 09 Feb 2008 10:42:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JNrqh-0003Oc-9T for grub-devel@gnu.org; Sat, 09 Feb 2008 10:42:43 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JNrqh-0003OP-0d for grub-devel@gnu.org; Sat, 09 Feb 2008 10:42:39 -0500 Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JNrqg-0003Sh-Nw for grub-devel@gnu.org; Sat, 09 Feb 2008 10:42:38 -0500 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JNrqZ-0000Zw-Av for grub-devel@gnu.org; Sat, 09 Feb 2008 15:42:31 +0000 Received: from crypt.ethx.net ([82.165.27.140]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 09 Feb 2008 15:42:31 +0000 Received: from sam by crypt.ethx.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 09 Feb 2008 15:42:31 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: grub-devel@gnu.org From: Sam Morris Date: Sat, 9 Feb 2008 15:42:24 +0000 (UTC) Message-ID: References: <1202409267.5010.2.camel@xerces> <20080208011029.GA4418@thorin> <20080208191539.GA24599@thorin> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: crypt.ethx.net User-Agent: Pan/0.132 (Waxed in Black) Sender: news X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] tell the user why they are in rescue mode X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Feb 2008 15:42:44 -0000 On Fri, 08 Feb 2008 20:15:39 +0100, Robert Millan wrote: > On Fri, Feb 08, 2008 at 06:44:26PM +0000, Sam Morris wrote: >> >> While that works, the output looks like this: >> >> Entering rescue mode... >> error: out of disk >> > _ >> >> Which does not present the information in the clearest possible way: it >> looks like the error happened in the rescue mode code, instead of the >> normal mode code. >> >> Also, the error message could be lost if any of the code between the >> start of grub_enter_rescue_mode and its call to grub_print_error itself >> triggers an error. >> >> For these reasons I think it's better to call grub_print_error from >> within grub_load_normal. > > Agreed. See attached patch. Does this work as expected ? Yes, it works fine. -- Sam Morris http://robots.org.uk/ PGP key id 1024D/5EA01078 3412 EA18 1277 354B 991B C869 B219 7FDB 5EA0 1078