All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: linux-btrfs@vger.kernel.org
Subject: Question about ext4 conversion and leaf size
Date: Fri, 3 Jan 2014 00:29:51 +0000 (UTC)	[thread overview]
Message-ID: <pan.2014.01.03.00.30.03@googlemail.com> (raw)


Conversion from ext4 works really well and is an important step for
adoption. After recently converting a large-ish device I noticed
dodgy performance, even after defragment & rebalance; noticeably
different from the quite good performance of a newly-created btrfs
with 16k leaf size, as is the default since recently.

So I went spelunking and found that the btrfs-convert logic indeed
uses the ext4 block size as leaf size (from #2220):
https://git.kernel.org/cgit/linux/kernel/git/mason/btrfs-progs.git/tree/btrfs-convert.c#n2245

This is typically 4096 bytes and explains the observed performance.

So while I'm basically familiar with btrfs's design, I know nothing
about the details of the conversion (I'm amazed that it works so well,
including rollback!) but can/should this not be updated to the new default
of 16k, or is there a strong necessary correlation between the ext4 block
size and the newly created btrfs?

thanks!
Holger


             reply	other threads:[~2014-01-03  0:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03  0:29 Holger Hoffstätte [this message]
2014-01-03 18:13 ` Question about ext4 conversion and leaf size David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2014.01.03.00.30.03@googlemail.com \
    --to=holger.hoffstaette@googlemail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.