From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: linux-btrfs@vger.kernel.org
Subject: Better handling of stale scrub status
Date: Tue, 20 May 2014 15:30:48 +0000 (UTC) [thread overview]
Message-ID: <pan.2014.05.20.15.30.48@googlemail.com> (raw)
As Marc Merlin recently wrote in his blog [1] scrub can sometimes leave a
stale state file behind, making cancel/resume complain. I took a peek at
the code and found most of the scrub state file handling fairly
straightforward, so before I go off and start hacking, what would a
better behaviour look like?
- delete the stale file?
- fix the file by setting the "finished" flag?
- something else entirely?
I currently lean towards fixing (and not printing an error?), but maybe
someone else has different ideas about how this should be handled.
Any suggestions welcome..
cheers
Holger
[1] http://marc.merlins.org/perso/btrfs/post_2014-04-26_Btrfs-Tips_-
Cancel-A-Btrfs-Scrub-That-Is-Already-Stopped.html
next reply other threads:[~2014-05-20 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 15:30 Holger Hoffstätte [this message]
2014-05-31 21:54 ` Better handling of stale scrub status Marc MERLIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pan.2014.05.20.15.30.48@googlemail.com \
--to=holger.hoffstaette@googlemail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.