All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix leaf corruption after __btrfs_drop_extents
Date: Fri, 6 Jun 2014 14:02:07 +0000 (UTC)	[thread overview]
Message-ID: <pan.2014.06.06.14.02.07@googlemail.com> (raw)
In-Reply-To: 1402035958-30013-1-git-send-email-bo.li.liu@oracle.com

On Fri, 06 Jun 2014 14:25:58 +0800, Liu Bo wrote:

> Several reports about leaf corruption has been floating on the list, one
> of them points to __btrfs_drop_extents(), and we find that the leaf
> becomes corrupted after __btrfs_drop_extents(), it's really a rare case
> but it does exist.

Out of curiosity ("..what could go wrong?" :) I applied this to 3.14.6, 
rebooted and worked a bit on my btrfs drive - rsyncs, create & delete 
snapshots etc. For the first time in ages I got two kernel messages:

Jun  6 09:20:56 tux kernel: BTRFS error (device sdb1): block group 
351872745472 has wrong amount of free space
Jun  6 09:20:56 tux kernel: BTRFS error (device sdb1): failed to load 
free space cache for block group 351872745472

I remounted without inode_cache & clear_cache, worked some more and so 
far no more messages. Could the messages be related to this patch? Or am 
I just looking at a coincidental/unrelated occurrence? Dropping the 
snapshots correctly freed up several GBs, so I assume that extents were 
dropped..

thanks
Holger


  parent reply	other threads:[~2014-06-06 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  6:25 [PATCH] Btrfs: fix leaf corruption after __btrfs_drop_extents Liu Bo
2014-06-06 12:11 ` Filipe David Manana
2014-06-08 10:54   ` Liu Bo
2014-06-08 11:11     ` Filipe David Manana
2014-06-08 11:16       ` Filipe David Manana
2014-06-06 14:02 ` Holger Hoffstätte [this message]
2014-06-08 11:07   ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2014.06.06.14.02.07@googlemail.com \
    --to=holger.hoffstaette@googlemail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.