Re: [PATCH] Btrfs: don't ignore log btree writeback errors

["Holger Hoffstätte" <holger.hoffstaette@googlemail.com>]

On Thu, 13 Nov 2014 17:50:44 +0000, Filipe David Manana wrote:

[snip]

>>> This first hunk didn't apply to my 3.14.x tree that is 99.999% in sync with
>>> btrfs-3.18+, as a line is missing from the context. See:
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/mason/linux-btrfs.git/tree/fs/btrfs/tree-log.c?h=for-linus#n2605
>>>
>>> Any idea where that missing btrfs_free_logged_extents() went?
>>
>> Found it: it went away with Josef's recent patch on Nov 6:
>> "Btrfs: make sure we wait on logged extents when fsycning two subvols"
>> (http://permalink.gmane.org/gmane.comp.file-systems.btrfs/40005)
>>
>> ..which I have applied. boohoo.
>>
>> That patch also adds another call to btrfs_wait_marked_extents(), which should
>> then probably also have its return value handled?
> 
> No, it's a different call - btrfs_wait_logged_extents().

Of course, you are right. I can't read (it's late :)

cheers
-h