All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aron Griffis <aron@hp.com>
To: xen-devel@lists.xensource.com
Cc: Christoph.Egger@amd.com, xen-ia64-devel@lists.xensource.com
Subject: [PATCH 0 of 2] Make tools cross-friendly, try 2
Date: Mon, 21 Jan 2008 10:29:31 -0500	[thread overview]
Message-ID: <patchbomb.1200929371@jenkins.nashua> (raw)

Hi,

This is an update of the patchset originally posted here:

http://lists.xensource.com/archives/html/xen-devel/2008-01/msg00620.html

This update includes changes suggested by Christoph's review,
in particular:
- fix vnconfig typo
- make the ldconfig logic better

That last fix actually behaves a bit differently than
before, but I think it's better to alert the user than
assume we can create the cache.  Here's the delta:

 	# This relatively common in a sys-root; libs are installed but
-	# ldconfig hasn't run there, so ldconfig -p won't work.  We can
-	# only fix it if it's writeable.
-	[ "$OS" != Linux ] || \
-	[ -f "$CROSS_SYS_ROOT/etc/ld.so.cache" ] || \
-	ldconfig -r "$CROSS_SYS_ROOT" && \
+	# ldconfig hasn't run there, so ldconfig -p won't work.
+	if [ "$OS" = Linux -a ! -f "$CROSS_SYS_ROOT/etc/ld.so.cache" ]; then
+	    echo "Please run ldconfig -r \"$CROSS_SYS_ROOT\" to generate ld.so.cache"
+	    # fall through; ldconfig test below should fail
+	fi
 	ldconfig -p ${CROSS_SYS_ROOT+-r "$CROSS_SYS_ROOT"} | grep -Fq "$1"
 	return $?

I did not revert the SunOS test.  I have a high degree of
confidence that it's correct, and IMHO it's better to be
consistent.

Thanks,
Aron

17 files changed, 160 insertions(+), 224 deletions(-)
tools/Makefile                  |   15 +++++-
tools/check/check_brctl         |   24 ++---------
tools/check/check_crypto_lib    |   20 +--------
tools/check/check_curl          |   41 +++---------------
tools/check/check_iproute       |   25 +++--------
tools/check/check_openssl_devel |   12 -----
tools/check/check_python        |   11 -----
tools/check/check_python_devel  |   11 -----
tools/check/check_python_xml    |    9 +---
tools/check/check_udev          |   31 +++-----------
tools/check/check_x11_devel     |   15 +-----
tools/check/check_xgettext      |   12 -----
tools/check/check_xml2          |   34 ++-------------
tools/check/check_zlib_devel    |   12 -----
tools/check/check_zlib_lib      |   18 +-------
tools/check/chk                 |    9 +---
tools/check/funcs.sh            |   85 +++++++++++++++++++++++++++++++++++++++

             reply	other threads:[~2008-01-21 15:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 15:29 Aron Griffis [this message]
2008-01-21 15:29 ` [PATCH 1 of 2] Make tools/Makefile cross-friendly Aron Griffis
2008-01-21 15:29 ` [PATCH 2 of 2] Make tools/check scripts cross-friendly Aron Griffis
2008-01-21 16:53 ` [PATCH 0 of 2] Make tools cross-friendly, try 2 Christoph Egger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=patchbomb.1200929371@jenkins.nashua \
    --to=aron@hp.com \
    --cc=Christoph.Egger@amd.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xen-ia64-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.