From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Cc: George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH 0 of 4] xentrace [v2]: non-contiguous allocation of per-cpu buffer
Date: Tue, 10 May 2011 16:32:35 +0200 [thread overview]
Message-ID: <patchbomb.1305037955@localhost> (raw)
This series implements non-contiguous trace buffers.
There was an overflow in the offset calculation because it was stored in
an int. Also the calculation of the per-cpu buffer did not take the type
of the offset value into account. This was the reason why I ran into the
checks in bogus(). The crash in out_dealloc: was caused by the lack of
check for the offset value.
Regarding the math added to next_record() another array of pointers could be
added to remove the mfn_to_virt() calls. In my testing 9343 trace pages on 8
cpus are used. Such an array would required additional (9343*8*8)/1024=583Kb.
Which is not too much, given the amount of 291MB tracebuffers.
Such a change is not part of this series.
Olaf
next reply other threads:[~2011-05-10 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 14:32 Olaf Hering [this message]
2011-05-10 14:32 ` [PATCH 1 of 4] xentrace: reduce trace buffer size to something mfn_offset can reach Olaf Hering
2011-05-26 10:05 ` George Dunlap
2011-05-10 14:32 ` [PATCH 2 of 4] xentrace: fix type of offset to avoid ouf-of-bounds access Olaf Hering
2011-05-26 10:05 ` George Dunlap
2011-05-10 14:32 ` [PATCH 3 of 4] xentrace: update __insert_record() to copy the trace record to individual mfns Olaf Hering
2011-05-26 10:06 ` George Dunlap
2011-05-10 14:32 ` [PATCH 4 of 4] xentrace: allocate non-contiguous per-cpu trace buffers Olaf Hering
2011-05-26 10:06 ` George Dunlap
2011-05-20 8:36 ` [PATCH 0 of 4] xentrace [v2]: non-contiguous allocation of per-cpu buffer Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=patchbomb.1305037955@localhost \
--to=olaf@aepfle.de \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.