From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH 0 of 3] libxl: domain shutdown cleanup Date: Tue, 13 Dec 2011 16:24:28 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: ian.jackson@citrix.com List-Id: xen-devel@lists.xenproject.org The existing libxl_domain_shutdown is a bit odd, it takes an integer "req" which can be used to indicate one of: * [0] = "poweroff", * [1] = "reboot", * [2] = "suspend", * [3] = "crash", * [4] = "halt", "suspend" is not usable via this interface since it requires other scaffolding, libxl_domain_suspend provides this already. "halt" is the same as "poweroff". "crash" is unused and at least Linux does not implement it. If a user steps forward then libxl_domain_crash is trivial to add. Therefore split libxl_domain_shutdown into libxl_domain_shutdown and libxl_domain_reboot corresponding to "poweroff" and "reboot" respectively. Also push responsibility for dealing with lack of PV drivers into the caller and at the same time improve the error messages presented to the user when they try and "xl shutdown/reboot" an HVM guest with no PV drivers and the corresponding documentation.