From: Petr Lautrbach <plautrba@redhat.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH userspace v2 4/4] Makefile: always build with -fno-common
Date: Tue, 28 Jan 2020 10:54:20 +0100 [thread overview]
Message-ID: <pjdblqnzz1v.fsf@redhat.com> (raw)
In-Reply-To: <20200123125716.12662-5-omosnace@redhat.com>
Ondrej Mosnacek <omosnace@redhat.com> writes:
> GCC 10 has it enabled by default and everything now builds OK with it,
> so add it to CFLAGS to avoid breaking the build in the future.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c238dbc8..298cd2b7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -16,7 +16,8 @@ else
> -Wstrict-prototypes \
> -Wundef \
> -Wunused \
> - -Wwrite-strings
> + -Wwrite-strings \
> + -fno-common
> endif
>
> ifneq ($(DESTDIR),)
This change applies only when you run a build from root directory.
Would it make sense to propagate it also to libsepol/src/Makefile and
checkpolicy/Makefile so it's used when users builds components from
released tar balls?
next prev parent reply other threads:[~2020-01-28 9:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 12:57 [PATCH userspace v2 0/4] Fix build with -fno-common Ondrej Mosnacek
2020-01-23 12:57 ` [PATCH userspace v2 1/4] libsepol: fix CIL_KEY_* build errors " Ondrej Mosnacek
2020-01-23 12:57 ` [PATCH userspace v2 2/4] libsepol: remove leftovers of cil_mem_error_handler Ondrej Mosnacek
2020-01-23 12:57 ` [PATCH userspace v2 3/4] checkpolicy: remove unused te_assertions Ondrej Mosnacek
2020-01-23 12:57 ` [PATCH userspace v2 4/4] Makefile: always build with -fno-common Ondrej Mosnacek
2020-01-23 18:26 ` [Non-DoD Source] " jwcart2
2020-01-28 9:54 ` Petr Lautrbach [this message]
2020-01-24 10:39 ` [PATCH userspace v2 0/4] Fix " Jason Zaman
2020-01-24 11:15 ` Ondrej Mosnacek
2020-01-27 15:56 ` [Non-DoD Source] " jwcart2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pjdblqnzz1v.fsf@redhat.com \
--to=plautrba@redhat.com \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.