From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69ECC43381 for ; Wed, 20 Feb 2019 10:07:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF84B20C01 for ; Wed, 20 Feb 2019 10:07:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726000AbfBTKHV (ORCPT ); Wed, 20 Feb 2019 05:07:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40116 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbfBTKHV (ORCPT ); Wed, 20 Feb 2019 05:07:21 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E90581F0E; Wed, 20 Feb 2019 10:07:20 +0000 (UTC) Received: from workstation (unknown [10.43.12.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6389819C5A; Wed, 20 Feb 2019 10:07:19 +0000 (UTC) References: <20190217213650.25974-1-nicolas.iooss@m4x.org> <20190217213650.25974-2-nicolas.iooss@m4x.org> User-agent: mu4e 1.0; emacs 26.1 From: Petr Lautrbach To: selinux@vger.kernel.org Cc: Nicolas Iooss , Petr Lautrbach Subject: Re: [PATCH 2/2] python: always use python3 in the shebang of programs using setools In-reply-to: Date: Wed, 20 Feb 2019 11:07:17 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 20 Feb 2019 10:07:20 +0000 (UTC) Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org Petr Lautrbach writes: > Nicolas Iooss writes: > >> setools 4.2.0 dropped support for Python 2. On systems where >> /usr/bin/python is Python 2, several tools are now broken >> because of >> this. Update the shebang of these tools to /usr/bin/python3. >> >> For future reference, as semanage/seobject.py, sepolicy and >> sepolgen >> import setools, every program that uses one of these modules >> need to be >> run with Python 3. The following programs do not use any of >> these >> modules so their shebangs have not been modified: >> >> dbus/selinux_server.py >> libsemanage/utils/semanage_migrate_store >> mcstrans/share/util/mlscolor-test >> mcstrans/share/util/mlstrans-test >> sandbox/start >> >> Signed-off-by: Nicolas Iooss > > Acked-by: Petr Lautrbach Both patches are merged already. >> --- >> gui/polgengui.py | 2 +- >> gui/system-config-selinux.py | 2 +- >> python/audit2allow/audit2allow | 2 +- >> python/audit2allow/sepolgen-ifgen | 2 +- >> python/chcat/chcat | 2 +- >> python/sepolicy/sepolicy.py | 2 +- >> sandbox/sandbox | 2 +- >> 7 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/gui/polgengui.py b/gui/polgengui.py >> index 1601dbef0e8d..b1cc99372434 100644 >> --- a/gui/polgengui.py >> +++ b/gui/polgengui.py >> @@ -1,4 +1,4 @@ >> -#!/usr/bin/python -Es >> +#!/usr/bin/python3 -Es >> # >> # polgengui.py - GUI for SELinux Config tool in >> system-config-selinux >> # >> diff --git a/gui/system-config-selinux.py >> b/gui/system-config-selinux.py >> index ce7c74b1333c..c42301b626fc 100644 >> --- a/gui/system-config-selinux.py >> +++ b/gui/system-config-selinux.py >> @@ -1,4 +1,4 @@ >> -#!/usr/bin/python -Es >> +#!/usr/bin/python3 -Es >> # >> # system-config-selinux.py - GUI for SELinux Config tool in >> system-config-selinux >> # >> diff --git a/python/audit2allow/audit2allow >> b/python/audit2allow/audit2allow >> index 18fe0a531d02..09b06f664bc4 100644 >> --- a/python/audit2allow/audit2allow >> +++ b/python/audit2allow/audit2allow >> @@ -1,4 +1,4 @@ >> -#! /usr/bin/python -Es >> +#!/usr/bin/python3 -Es >> # Authors: Karl MacMillan >> # Authors: Dan Walsh >> # >> diff --git a/python/audit2allow/sepolgen-ifgen >> b/python/audit2allow/sepolgen-ifgen >> index c482f227193f..be2d093be597 100644 >> --- a/python/audit2allow/sepolgen-ifgen >> +++ b/python/audit2allow/sepolgen-ifgen >> @@ -1,4 +1,4 @@ >> -#! /usr/bin/python -Es >> +#!/usr/bin/python3 -Es >> # >> # Authors: Karl MacMillan >> # >> diff --git a/python/chcat/chcat b/python/chcat/chcat >> index 5bef0073b7a4..ba398684376d 100755 >> --- a/python/chcat/chcat >> +++ b/python/chcat/chcat >> @@ -1,4 +1,4 @@ >> -#! /usr/bin/python -Es >> +#!/usr/bin/python3 -Es >> # Copyright (C) 2005 Red Hat >> # see file 'COPYING' for use and warranty information >> # >> diff --git a/python/sepolicy/sepolicy.py >> b/python/sepolicy/sepolicy.py >> index 8cc7e8cc5c1c..1934cd8620b0 100755 >> --- a/python/sepolicy/sepolicy.py >> +++ b/python/sepolicy/sepolicy.py >> @@ -1,4 +1,4 @@ >> -#! /usr/bin/python -Es >> +#!/usr/bin/python3 -Es >> # Copyright (C) 2012 Red Hat >> # AUTHOR: Dan Walsh >> # see file 'COPYING' for use and warranty information >> diff --git a/sandbox/sandbox b/sandbox/sandbox >> index c07a1d812a13..1dec07acdcb8 100644 >> --- a/sandbox/sandbox >> +++ b/sandbox/sandbox >> @@ -1,4 +1,4 @@ >> -#! /usr/bin/python -Es >> +#!/usr/bin/python3 -Es >> # Authors: Dan Walsh >> # Authors: Thomas Liu >> # Authors: Josh Cogliati